[pacman-dev] Fwd: [PATCH] makepkg.conf: Added .svn to PURGE_TARGETS
--- etc/makepkg.conf.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/etc/makepkg.conf.in b/etc/makepkg.conf.in index f0d1c44..c721209 100644 --- a/etc/makepkg.conf.in +++ b/etc/makepkg.conf.in @@ -85,7 +85,7 @@ DOC_DIRS=(usr/{,local/}{,share/}{doc,gtk-doc} opt/*/{doc,gtk-doc}) #-- Directories to be searched for the strip option (if strip is specified) STRIP_DIRS=(bin lib sbin usr/{bin,lib,sbin,local/{bin,lib,sbin}} opt/*/{bin,lib,sbin}) #-- Files to be removed from all packages (if purge is specified) -PURGE_TARGETS=(usr/{,share}/info/dir .packlist *.pod) +PURGE_TARGETS=(usr/{,share}/info/dir .packlist *.pod .svn) ######################################################################### # PACKAGE OUTPUT -- 1.7.0
On Thu, Mar 25, 2010 at 12:46 PM, Daenyth Blank
--- etc/makepkg.conf.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/etc/makepkg.conf.in b/etc/makepkg.conf.in index f0d1c44..c721209 100644 --- a/etc/makepkg.conf.in +++ b/etc/makepkg.conf.in @@ -85,7 +85,7 @@ DOC_DIRS=(usr/{,local/}{,share/}{doc,gtk-doc} opt/*/{doc,gtk-doc}) #-- Directories to be searched for the strip option (if strip is specified) STRIP_DIRS=(bin lib sbin usr/{bin,lib,sbin,local/{bin,lib,sbin}} opt/*/{bin,lib,sbin}) #-- Files to be removed from all packages (if purge is specified) -PURGE_TARGETS=(usr/{,share}/info/dir .packlist *.pod) +PURGE_TARGETS=(usr/{,share}/info/dir .packlist *.pod .svn)
######################################################################### # PACKAGE OUTPUT -- 1.7.0
<<<explanation belongs here>>>
On second thought, it's not really needed. The original rationale was that it would be good to remove them as they can get accidently installed when building from an svn snapshot, but proper packaging pretty much precludes them being installed anyway. Additionally, there's no packages in the repos right now which have .svn dirs in them, so it's clearly not an actual problem.
On 26/03/2010, Daenyth Blank
<<<explanation belongs here>>>
On second thought, it's not really needed. The original rationale was that it would be good to remove them as they can get accidently installed when building from an svn snapshot, but proper packaging pretty much precludes them being installed anyway. Additionally, there's no packages in the repos right now which have .svn dirs in them, so it's clearly not an actual problem.
This may not be a quantified solution, but adds a theoretical benefit for when there actually is a .svn directory. Now, personally, I think it's an OK-addition, along with .git and others, i.e "purge_vcsdirs()". And of course, since makepkg.conf (and PURGE_TARGETS) is user-editable, there's no need to make it a default since we haven't even an actual case to show. -- GPG/PGP ID: B42DDCAD
participants (3)
-
Daenyth Blank
-
Dan McGee
-
Ray Rashif