[pacman-dev] [PATCH] Remove a pm_errno = 0 line
In the download code a successful package-download could reset the previously
set pm_errno to 0, which is unwanted.
Signed-off-by: Nagy Gabor
In the download code a successful package-download could reset the previously set pm_errno to 0, which is unwanted.
Signed-off-by: Nagy Gabor
This patch needs testing. Btw, I can see more pm_errno = 0 line in the code, which is not a good practice... NG
On Wed, Feb 8, 2012 at 11:06 PM, Nagy Gabor
In the download code a successful package-download could reset the previously set pm_errno to 0, which is unwanted.
Signed-off-by: Nagy Gabor
This patch needs testing. Btw, I can see more pm_errno = 0 line in the code, which is not a good practice... We don't just do this for fun, it is necessary practice in several cases. Please consider the following patch which you are reverting...
commit b008193c1255639f724e3f6c62e50e6f2619e3c2
Author: Dave Reisner
On Wed, Feb 8, 2012 at 11:06 PM, Nagy Gabor
wrote: In the download code a successful package-download could reset the previously set pm_errno to 0, which is unwanted.
Signed-off-by: Nagy Gabor
This patch needs testing. Btw, I can see more pm_errno = 0 line in the code, which is not a good practice... We don't just do this for fun, it is necessary practice in several cases. Please consider the following patch which you are reverting...
Yeah, I've just sent an other answer to this thread...
In the download code a successful package-download could reset the previously set pm_errno to 0, which is unwanted.
Signed-off-by: Nagy Gabor
This patch needs testing. Btw, I can see more pm_errno = 0 line in the code, which is not a good practice...
NG
I revoke this patch. That pm_errno = 0 line is there for indicating the successful download of the same file from an other mirror. As a side effect, every successful download clears the "pm_errno history". This is again a design limitation (this should be handled in sync.c). :-(
participants (2)
-
Dan McGee
-
Nagy Gabor