[pacman-dev] Makepkg missing check for empty pkgname
I thought it was wierd that makepkg didn't do a sanity check for the $pkgname. This makes for a simple first try at a GIT patch. Can outgoing SMTP be setup on patch generation? Seems silly to import a text file in evolution everytime... Signed-off-by: K. Piche <kevin@archlinux.org> --- scripts/makepkg.sh.in | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index ef7bae5..f37772a 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1288,6 +1288,10 @@ fi source "$BUILDSCRIPT" # check for no-no's in the build script +if [ -z "$pkgname" ]; then + error "$(gettext "%s is not allowed to be empty.")" "pkgname" + exit 1 +fi if [ -z "$pkgver" ]; then error "$(gettext "%s is not allowed to be empty.")" "pkgver" exit 1 -- 1.5.3.7 -- K. Piche <kpiche@rogers.com>
On Dec 22, 2007 5:58 PM, K. Piche <kpiche@rogers.com> wrote:
I thought it was wierd that makepkg didn't do a sanity check for the $pkgname. This makes for a simple first try at a GIT patch.
Merged, thanks.
Can outgoing SMTP be setup on patch generation? Seems silly to import a text file in evolution everytime...
I have msmtp set up as a simple way to send emails using the git tools. Here is the basic setup: 1. Install msmtp 2. Set up a config file at ~/.msmtprc (man msmtp) 3. Set up GIT to use msmtp (git config --global sendemail.smtpserver "/usr/bin/msmtp") 4. git send-email <patchfiles>, then fill in the blanks -Dan
participants (2)
-
Dan McGee
-
K. Piche