[pacman-dev] [PATCH] Print warning in _alpm_resolvedep() if a satisfier package is ignored without QUESTION
From fe694f5e78a93284a28c4afd1a9272dac565b29b Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba@bibl.u-szeged.hu> Date: Wed, 4 Mar 2009 20:34:06 +0100 Subject: [PATCH] Print warning in _alpm_resolvedep() if a satisfier package is ignored without QUESTION
After commit f57f8d33862050acc8d131710c100ba47877e675 pacman *silently* ignores packages from IgnorePkg/IgnoreGroup during dependency resolving, if prompt == 0. This behavior is changed to "give warning + ignore". (Otherwise the user is not informed about the fact that the package resolving was blocked by ignorepkg.) Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu> --- lib/libalpm/deps.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c index dd5bd20..36f4d35 100644 --- a/lib/libalpm/deps.c +++ b/lib/libalpm/deps.c @@ -530,6 +530,8 @@ pmpkg_t *_alpm_resolvedep(pmdepend_t *dep, alpm_list_t *dbs, if (prompt) { QUESTION(handle->trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, pkg, NULL, NULL, &install); + } else { + _alpm_log(PM_LOG_WARNING, _("ignoring package %s-%s\n"), pkg->name, pkg->version); } if(!install) { ignored = 1; @@ -550,6 +552,8 @@ pmpkg_t *_alpm_resolvedep(pmdepend_t *dep, alpm_list_t *dbs, if (prompt) { QUESTION(handle->trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, pkg, NULL, NULL, &install); + } else { + _alpm_log(PM_LOG_WARNING, _("ignoring package %s-%s\n"), pkg->name, pkg->version); } if(!install) { ignored = 1; -- 1.6.0.3
2009. 03. 4, szerda keltezéssel 20.51-kor Nagy Gabor ezt írta:
From fe694f5e78a93284a28c4afd1a9272dac565b29b Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba@bibl.u-szeged.hu> Date: Wed, 4 Mar 2009 20:34:06 +0100 Subject: [PATCH] Print warning in _alpm_resolvedep() if a satisfier package is ignored without QUESTION
After commit f57f8d33862050acc8d131710c100ba47877e675 pacman *silently* ignores packages from IgnorePkg/IgnoreGroup during dependency resolving, if prompt == 0. This behavior is changed to "give warning + ignore". (Otherwise the user is not informed about the fact that the package resolving was blocked by ignorepkg.)
Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu>
This patch is mainly a complaint about the current behavior, an other possible implementation is to use/rework my (not yet accepted) new PM_ERR_PKG_IGNORED error type. (However, it is not very informative without saying which packages were ignored.) Bye
participants (1)
-
Nagy Gabor