[pacman-dev] [patch] for sync1003.py
Hi! Patch attached. NOTE: this affects resolvedeps too. TODO: I did a dirty hack in sync_prepare (now sync990.py fails), I will clean it up later. Bye, ngaba
TODO: I did a dirty hack in sync_prepare (now sync990.py fails), I will Well, that patch is broken: pkg3 should be installed (pkg1 needs it.) Bye, ngaba
---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/
TODO: I did a dirty hack in sync_prepare (now sync990.py fails), I will Well, that patch is broken: pkg3 should be installed (pkg1 needs it.) Bye, ngaba Hm, sorry for duplicates ;-)
---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/
On Fri, Aug 03, 2007 at 09:02:43PM +0200, ngaba@bibl.u-szeged.hu wrote:
TODO: I did a dirty hack in sync_prepare (now sync990.py fails), I will Well, that patch is broken: pkg3 should be installed (pkg1 needs it.)
I think you meant pactest here, not patch. In this case, I agree that sync990 pactest looks broken. If a package foo is providen by package bar, then other packages should depend on foo, not bar. AFAIK, that's always the case in practice, so it shouldn't matter to define this rule. So for this particular pactest, pkg1 should depend on pkg2 (provided by pkg3) instead of pkg3. But then the pactest doesn't make much sense anymore.
I think you meant pactest here, not patch. Yes ;-)
---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/
TODO: I did a dirty hack in sync_prepare (now sync990.py fails), I will Well, that patch is broken: pkg3 should be installed (pkg1 needs it.) Bye, ngaba
---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/
TODO: I did a dirty hack in sync_prepare (now sync990.py fails), I will Well, that patch is broken: pkg3 should be installed (pkg1 needs it.) Bye, ngaba
---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/
TODO: I did a dirty hack in sync_prepare (now sync990.py fails), I will Well, that patch is broken: pkg3 should be installed (pkg1 needs it.) Bye, ngaba
---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/
Well, I know that you don't like patch-for-patch, but this patch won't touch the "heart" of the patch, this reverts my broken changes in sync.c only. Bye, ngaba ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/
On 8/4/07, ngaba@bibl.u-szeged.hu <ngaba@bibl.u-szeged.hu> wrote:
Well, I know that you don't like patch-for-patch, but this patch won't touch the "heart" of the patch, this reverts my broken changes in sync.c only.
Please resubmit the original patch with changes. This flat out doesn't work - there's no way to know what patch you just patched, and no way to comment on the workings of the patch itself.
Hi! The revert.diff was sent for checkdeps.diff, but now I merged the 2 patches (attached). Bye ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/
participants (4)
-
Aaron Griffin
-
Nagy Gabor
-
ngaba＠bibl.u-szeged.hu
-
Xavier