[pacman-dev] [PATCH] meson: use 'pedantic' compiler warning level
Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com> --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 572526b2..fc81fa27 100644 --- a/meson.build +++ b/meson.build @@ -7,6 +7,7 @@ project('pacman', 'prefix=/usr', 'sysconfdir=/etc', 'localstatedir=/var', + 'warning_level=3', ], meson_version : '>= 0.51') -- 2.25.1
On 3/5/20 7:42 PM, Anatol Pomozov wrote:
We can just use meson setup --warnlevel 3, the other settings there are about making sure the software works as expected. FWIW, meson.build already adds a bunch of -W flags automatically for buildtype=debug. This would be a better place to go adding even more. -- Eli Schwartz Bug Wrangler and Trusted User
On 6/3/20 10:50 am, Eli Schwartz wrote:
Agreed. I'm considering "buildtype=debug" to be the equivalent of "--enable-git-version --enable-debug --enable-warningflags" in autotools land. A
On 6/3/20 11:08 am, Allan McRae wrote:
Also... I thought all warning flags from autotools were transferred to meson. What specific flag is being missed here? Allan
Hi On Thu, Mar 5, 2020 at 4:50 PM Eli Schwartz <eschwartz@archlinux.org> wrote:
I see, so the compiler warnings (including the GNU escape symbols detection) are enabled at Debug mode only. What is the reason avoid compile warnings with the Release mode? 'meson setup' uses Release mode by default (unless no cmdline options override it) and I bet most of the contributors are just going to use this default. Having warnings enabled with the default setup eliminates potential WTF moments.
Hi On Thu, Mar 5, 2020 at 6:14 PM Eli Schwartz <eschwartz@archlinux.org> wrote:
Indeed you are right, meson enables debug mode by default. Sorry for the red herring. Returning back to the original question. Can we have a parity in compiler warnings between Make and Meson? I see that Make uses -Wpedantic by default while Meson does not.
On 6/3/20 2:51 pm, Anatol Pomozov wrote:
I will happily accept a patch adding -Wpedantic to meson. A
Hi On Thu, Mar 5, 2020 at 9:07 PM Allan McRae <allan@archlinux.org> wrote:
Eli, could you please take a look at it?
Hello In this case I would like to propose to move forward with my original patch and enable 'pedantic' warning level by default. It will match the flag with the Makefile based build. On Fri, Mar 6, 2020 at 3:52 PM Anatol Pomozov <anatol.pomozov@gmail.com> wrote:
On 3/26/20 3:32 PM, Anatol Pomozov wrote:
- We always defaulted to -pedantic -D_GNU_SOURCE -Wall in autotools, plus additional flags if --enable-warningflags - meson will, with warning_level 3, add -Wall -Wextra -Wpedantic, which means this patch would add the heretofore-unseen -Wextra (warning_level 1 only adds -Wall, 2 adds -Wall -Wextra, no option is available for those who like -Wpedantic but don't want -Wextra) Since autotools unconditionally added these flags, parity suggests always adding them in meson too. Do we care about -Wextra? We currently build with -Wextra without warnings being emitted, anyway. If -Wextra is fine then we can just take this current patch, but amend it to add -Wextra to configure.ac near ``` if test "x$debug" = "xyes" ; then ``` Anatol, can you also update the commit message to mention that this is implementing parity with the default autotools warning level? -- Eli Schwartz Bug Wrangler and Trusted User
Hi On Thu, Mar 26, 2020 at 1:42 PM Eli Schwartz <eschwartz@archlinux.org> wrote:
Sure, will send an updated patch in a minute. PTAL.
participants (3)
-
Allan McRae
-
Anatol Pomozov
-
Eli Schwartz