On 6/3/20 10:50 am, Eli Schwartz wrote:

On 3/5/20 7:42 PM, Anatol Pomozov wrote:

...

Signed-off-by: Anatol Pomozov --- meson.build | 1 + 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build index 572526b2..fc81fa27 100644 --- a/meson.build +++ b/meson.build @@ -7,6 +7,7 @@ project('pacman', 'prefix=/usr', 'sysconfdir=/etc', 'localstatedir=/var', + 'warning_level=3',

We can just use meson setup --warnlevel 3, the other settings there are about making sure the software works as expected.

FWIW, meson.build already adds a bunch of -W flags automatically for buildtype=debug. This would be a better place to go adding even more.

Agreed. I'm considering "buildtype=debug" to be the equivalent of "--enable-git-version --enable-debug --enable-warningflags" in autotools land. A

Hi On Thu, Mar 5, 2020 at 4:50 PM Eli Schwartz wrote:

On 3/5/20 7:42 PM, Anatol Pomozov wrote:

...

Signed-off-by: Anatol Pomozov --- meson.build | 1 + 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build index 572526b2..fc81fa27 100644 --- a/meson.build +++ b/meson.build @@ -7,6 +7,7 @@ project('pacman', 'prefix=/usr', 'sysconfdir=/etc', 'localstatedir=/var', + 'warning_level=3',

We can just use meson setup --warnlevel 3, the other settings there are about making sure the software works as expected.

FWIW, meson.build already adds a bunch of -W flags automatically for buildtype=debug. This would be a better place to go adding even more.

I see, so the compiler warnings (including the GNU escape symbols detection) are enabled at Debug mode only. What is the reason avoid compile warnings with the Release mode? 'meson setup' uses Release mode by default (unless no cmdline options override it) and I bet most of the contributors are just going to use this default. Having warnings enabled with the default setup eliminates potential WTF moments.

On 3/5/20 9:12 PM, Eli Schwartz wrote:

On 3/5/20 9:02 PM, Anatol Pomozov wrote:

...

Hi

On Thu, Mar 5, 2020 at 4:50 PM Eli Schwartz wrote:

...

On 3/5/20 7:42 PM, Anatol Pomozov wrote:

...

Signed-off-by: Anatol Pomozov --- meson.build | 1 + 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build index 572526b2..fc81fa27 100644 --- a/meson.build +++ b/meson.build @@ -7,6 +7,7 @@ project('pacman', 'prefix=/usr', 'sysconfdir=/etc', 'localstatedir=/var', + 'warning_level=3',

We can just use meson setup --warnlevel 3, the other settings there are about making sure the software works as expected.

FWIW, meson.build already adds a bunch of -W flags automatically for buildtype=debug. This would be a better place to go adding even more.

I see, so the compiler warnings (including the GNU escape symbols detection) are enabled at Debug mode only.

What is the reason avoid compile warnings with the Release mode? 'meson setup' uses Release mode by default (unless no cmdline options override it)

Incorrect, meson setup defaults to --buildtype=plain.

Err, I mean --buildtype=debug, obviously "plain" would be very much not "debug"...

Are you using an alias or wrapper script to run meson? That might add additional options you've forgotten about.

...

and I bet most of the contributors are just going to use this default. Having warnings enabled with the default setup eliminates potential WTF moments.

-- Eli Schwartz Bug Wrangler and Trusted User

On 6/3/20 2:51 pm, Anatol Pomozov wrote:

Hi

On Thu, Mar 5, 2020 at 6:14 PM Eli Schwartz wrote:

...

On 3/5/20 9:12 PM, Eli Schwartz wrote:

...

On 3/5/20 9:02 PM, Anatol Pomozov wrote:

...

Hi

On Thu, Mar 5, 2020 at 4:50 PM Eli Schwartz wrote:

...

On 3/5/20 7:42 PM, Anatol Pomozov wrote:

...

Signed-off-by: Anatol Pomozov --- meson.build | 1 + 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build index 572526b2..fc81fa27 100644 --- a/meson.build +++ b/meson.build @@ -7,6 +7,7 @@ project('pacman', 'prefix=/usr', 'sysconfdir=/etc', 'localstatedir=/var', + 'warning_level=3',

We can just use meson setup --warnlevel 3, the other settings there are about making sure the software works as expected.

FWIW, meson.build already adds a bunch of -W flags automatically for buildtype=debug. This would be a better place to go adding even more.

I see, so the compiler warnings (including the GNU escape symbols detection) are enabled at Debug mode only.

What is the reason avoid compile warnings with the Release mode? 'meson setup' uses Release mode by default (unless no cmdline options override it)

Incorrect, meson setup defaults to --buildtype=plain.

Err, I mean --buildtype=debug, obviously "plain" would be very much not "debug"...

Indeed you are right, meson enables debug mode by default. Sorry for the red herring.

Returning back to the original question. Can we have a parity in compiler warnings between Make and Meson? I see that Make uses -Wpedantic by default while Meson does not.

I will happily accept a patch adding -Wpedantic to meson. A

Hello In this case I would like to propose to move forward with my original patch and enable 'pedantic' warning level by default. It will match the flag with the Makefile based build. On Fri, Mar 6, 2020 at 3:52 PM Anatol Pomozov wrote:

Hi

On Thu, Mar 5, 2020 at 9:07 PM Allan McRae wrote:

...

On 6/3/20 2:51 pm, Anatol Pomozov wrote:

...

Hi

On Thu, Mar 5, 2020 at 6:14 PM Eli Schwartz wrote:

...

On 3/5/20 9:12 PM, Eli Schwartz wrote:

...

On 3/5/20 9:02 PM, Anatol Pomozov wrote:

...

Hi

On Thu, Mar 5, 2020 at 4:50 PM Eli Schwartz wrote: > > On 3/5/20 7:42 PM, Anatol Pomozov wrote: >> Signed-off-by: Anatol Pomozov >> --- >> meson.build | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meson.build b/meson.build >> index 572526b2..fc81fa27 100644 >> --- a/meson.build >> +++ b/meson.build >> @@ -7,6 +7,7 @@ project('pacman', >> 'prefix=/usr', >> 'sysconfdir=/etc', >> 'localstatedir=/var', >> + 'warning_level=3', > > We can just use meson setup --warnlevel 3, the other settings there are > about making sure the software works as expected. > > FWIW, meson.build already adds a bunch of -W flags automatically for > buildtype=debug. This would be a better place to go adding even more.

I see, so the compiler warnings (including the GNU escape symbols detection) are enabled at Debug mode only.

What is the reason avoid compile warnings with the Release mode? 'meson setup' uses Release mode by default (unless no cmdline options override it)

Incorrect, meson setup defaults to --buildtype=plain.

Err, I mean --buildtype=debug, obviously "plain" would be very much not "debug"...

Indeed you are right, meson enables debug mode by default. Sorry for the red herring.

Returning back to the original question. Can we have a parity in compiler warnings between Make and Meson? I see that Make uses -Wpedantic by default while Meson does not.

I will happily accept a patch adding -Wpedantic to meson.

Eli, could you please take a look at it?