This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 2cfcc874b9332ad207398b9e20dc8880d93e8ae4 (commit) via dc3336c27728fc16d2f9e68cb818648e7ca88467 (commit) via c7e4005e5ced965db49d73067fe40c516b6c34df (commit) via de43d00db071a04653cff592607647bb9c01d025 (commit) via 12387ca4e5c16994bacad52c142ef94868ba545a (commit) via 0dad2f6e6223e2aa00c43b59f49bf83082a0d6bb (commit) via a12a4ea3960c98817aa60df5a8879d118a16e2a7 (commit) via 455ca55f4efecf48bf86904e4a67a4b124cf1838 (commit) via a2002b8f690e12a7e8c75a3a9184570d27709c71 (commit) via 87fb8f5d5795be9b2bcb025eac26c94d7bb1e7b3 (commit) via 84d6de806bd18f4a6c0940de5ee60904f650539c (commit) via 5a07b75b225cbc731fbfb915a9c9edf0c300ccc4 (commit) via be72e100159e6cd50ac64e3639f8e4f98218ccae (commit) via c5982a3eb5287afdec6c9b859f81795c773da8fe (commit) from e1dce078b247142f7db80bf2d338e431df34691e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2cfcc874b9332ad207398b9e20dc8880d93e8ae4 Author: Dan McGee Date: Thu Aug 25 18:29:00 2011 -0500 Better error handling out of package load method There are many other ways to fail a package load other than "file not found". We should also use the correct error code in this case. Clean it up a bit in the various callers. Signed-off-by: Dan McGee commit dc3336c27728fc16d2f9e68cb818648e7ca88467 Author: Dan McGee Date: Thu Aug 25 16:40:39 2011 -0500 Refactor some args out of pkg_load_internal Just pass the entire sync package in if we have it; that way we can do any necessary operations involving it rather than have a parameter list growing endlessly. Signed-off-by: Dan McGee commit c7e4005e5ced965db49d73067fe40c516b6c34df Author: Dan McGee Date: Thu Aug 25 10:29:02 2011 -0500 Add more info to debug key display Signed-off-by: Dan McGee commit de43d00db071a04653cff592607647bb9c01d025 Author: Dan McGee Date: Wed Aug 24 13:24:42 2011 -0500 Refactor signature result return format I was trying to take a shortcut and not introduce a wrapper struct for the signature results, so packed it all into alpm_sigresult_t in the first iteration. However, this is painful when one wants to add new fields or only return information regarding a single signature. Refactor the type into a few components which are exposed to the end user, and will allow a lot more future flexibility. This also exposes more information regarding the key to the frontend than was previously available. The "private" void *data pointer is used by the library to store the actual key object returned by gpgme; it is typed this way so the frontend has no expectations of what is there, and so we don't have any hard gpgme requirement in our public API. Signed-off-by: Dan McGee commit 12387ca4e5c16994bacad52c142ef94868ba545a Author: Diogo Sousa Date: Sat Aug 27 22:03:45 2011 +0100 lib/libalpm/signing.c: Fix memory leak in decode_signature() in case of error. Signed-off-by: Diogo Sousa Signed-off-by: Dan McGee commit 0dad2f6e6223e2aa00c43b59f49bf83082a0d6bb Author: Lukas Fleischer Date: Fri Aug 26 13:10:38 2011 +0200 lib/libalpm/util.c: Fix two memory leaks Free "md5sum" if md5_file() fails in alpm_compute_md5sum(). Free "sha256sum" if sha2_file() fails in alpm_compute_sha256sum(). Signed-off-by: Lukas Fleischer Signed-off-by: Dan McGee commit a12a4ea3960c98817aa60df5a8879d118a16e2a7 Author: Dan McGee Date: Sun Aug 28 19:46:09 2011 -0500 Check local database status flag in db_write sanity check block Do all the checks at once; this also avoids the 'return' call after we have allocated memory for "pkgpath" as well as tweaked the umask. Signed-off-by: Dan McGee commit 455ca55f4efecf48bf86904e4a67a4b124cf1838 Author: Lukas Fleischer Date: Fri Aug 26 13:10:37 2011 +0200 be_sync.c: Fix memory leak in alpm_db_update() Free "syncpath" and restore umask if we fail to grab a lock. Signed-off-by: Lukas Fleischer Signed-off-by: Dan McGee commit a2002b8f690e12a7e8c75a3a9184570d27709c71 Author: Lukas Fleischer Date: Fri Aug 26 13:10:35 2011 +0200 pacman.c: Remove redundant strdup() in parsearg_global() config_set_arch() already calls strdup(). Remove strdup() from the config_set_arch() invocation to avoid a memory leak. Signed-off-by: Lukas Fleischer Signed-off-by: Dan McGee commit 87fb8f5d5795be9b2bcb025eac26c94d7bb1e7b3 Author: Dan McGee Date: Thu Aug 25 18:37:23 2011 -0500 Make sync error message smarter on unfound targets We had two issues here. One is a file with an absolute path passed to -S results in a cryptic error message due to the database name being '\0'. The second is not realizing you should be doing -U instead of -S. Fix both of these to transform this: $ sudo pacman -S /tmp/binutils-2.21.1-2-i686.pkg.tar.xz error: database not found: to this: $ sudo pacman -S /tmp/binutils-2.21.1-2-i686.pkg.tar.xz error: target not found: /tmp/binutils-2.21.1-2-i686.pkg.tar.xz warning: '/tmp/binutils-2.21.1-2-i686.pkg.tar.xz' is a file, did you mean -U/--upgrade instead of -S/--sync? Signed-off-by: Dan McGee commit 84d6de806bd18f4a6c0940de5ee60904f650539c Author: Dan McGee Date: Sat Aug 27 08:45:39 2011 -0500 Fix possible mismatched type with several curl arguments After commit 2e7d0023150664, we use off_t rather than long variables. Use the _LARGE variants of the methods to indicate we are passing off_t sized variables, and cast using (curl_off_t) accordingly. Signed-off-by: Dan McGee commit 5a07b75b225cbc731fbfb915a9c9edf0c300ccc4 Author: Dan McGee Date: Thu Aug 25 17:41:47 2011 -0500 Always process validity value returned by gpgme Don't force 'never'; you should be checking both the status and validity anyway. Signed-off-by: Dan McGee commit be72e100159e6cd50ac64e3639f8e4f98218ccae Author: Dan McGee Date: Thu Aug 25 17:41:27 2011 -0500 Fix small memory leak in sig check code Signed-off-by: Dan McGee commit c5982a3eb5287afdec6c9b859f81795c773da8fe Author: Dan McGee Date: Thu Aug 25 17:14:19 2011 -0500 strtrim: don't move empty string There were many cases where the string coming in was a blank line, e.g. "\n\0", length 1. The trim routine starts by trimming leading spaces, thus trimming everything. We would then proceed to do a memmove of the NULL byte, which is completely worthless as we can just assign it instead. Signed-off-by: Dan McGee ----------------------------------------------------------------------- Summary of changes: lib/libalpm/alpm.h | 28 +++++++--- lib/libalpm/be_local.c | 6 +-- lib/libalpm/be_package.c | 68 ++++++++++++----------- lib/libalpm/be_sync.c | 2 + lib/libalpm/dload.c | 6 ++- lib/libalpm/package.h | 3 +- lib/libalpm/signing.c | 133 ++++++++++++++++++++++----------------------- lib/libalpm/signing.h | 2 +- lib/libalpm/sync.c | 3 +- lib/libalpm/util.c | 9 +++- src/pacman/package.c | 8 ++-- src/pacman/pacman.c | 2 +- src/pacman/query.c | 14 ++++- src/pacman/sync.c | 9 ++- src/pacman/util.c | 22 +++++--- src/pacman/util.h | 2 +- src/util/pactree.c | 7 ++- src/util/testpkg.c | 3 + valgrind.supp | 1 - 19 files changed, 186 insertions(+), 142 deletions(-) hooks/post-receive -- The official pacman repository