[pacman-dev] [PATCHv2 1/2] proto: Remove recommendation of "makepkg -g" in comments
This recommendation encouraged the practice of not checking the checksums provided upstream. Signed-off-by: Jason St. John <jstjohn@purdue.edu> --- This is a resubmission based on Allan's feedback here: https://mailman.archlinux.org/pipermail/pacman-dev/2014-January/018570.html proto/PKGBUILD-split.proto | 2 +- proto/PKGBUILD.proto | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/proto/PKGBUILD-split.proto b/proto/PKGBUILD-split.proto index d0978d7..dd73f93 100644 --- a/proto/PKGBUILD-split.proto +++ b/proto/PKGBUILD-split.proto @@ -28,7 +28,7 @@ changelog= source=("$pkgbase-$pkgver.tar.gz" "$pkgname-$pkgver.patch") noextract=() -md5sums=() #generate with 'makepkg -g' +md5sums=() prepare() { cd "$pkgname-$pkgver" diff --git a/proto/PKGBUILD.proto b/proto/PKGBUILD.proto index 8d26c81..12816e0 100644 --- a/proto/PKGBUILD.proto +++ b/proto/PKGBUILD.proto @@ -27,7 +27,7 @@ changelog= source=("$pkgname-$pkgver.tar.gz" "$pkgname-$pkgver.patch") noextract=() -md5sums=() #generate with 'makepkg -g' +md5sums=() prepare() { cd "$pkgname-$pkgver" -- 1.8.5.3
The change log prototype should be distribution determined. Signed-off-by: Jason St. John <jstjohn@purdue.edu> --- This is a resubmission based on Allan's feedback here: https://mailman.archlinux.org/pipermail/pacman-dev/2014-January/018651.html doc/PKGBUILD.5.txt | 1 + proto/ChangeLog.proto | 16 ---------------- 2 files changed, 1 insertion(+), 16 deletions(-) delete mode 100644 proto/ChangeLog.proto diff --git a/doc/PKGBUILD.5.txt b/doc/PKGBUILD.5.txt index 6c5ef84..0638942 100644 --- a/doc/PKGBUILD.5.txt +++ b/doc/PKGBUILD.5.txt @@ -102,6 +102,7 @@ below). *changelog*:: Specifies a changelog file that is to be included in the package. + The changelog file should end in a single newline. This file should reside in the same directory as the PKGBUILD and will be copied into the package by makepkg. It does not need to be included in the source array (e.g., `changelog=$pkgname.changelog`). diff --git a/proto/ChangeLog.proto b/proto/ChangeLog.proto deleted file mode 100644 index 87e86e7..0000000 --- a/proto/ChangeLog.proto +++ /dev/null @@ -1,16 +0,0 @@ -2007-12-01 Your Name <youremail@domain.com> - - * pkgver-pkgrel : - new upstream release. - Reason we changed stuff. - Another reason we changed stuff. - - * gcc-4.1.patch : - Removed, no longer needed. - -2007-11-01 Your Name <youremail@domain.com> - - * 1.0-5 : - added ChangeLog. - the last line should end with just one newline. - you can cat the file to check it displays fine. -- 1.8.5.3
On 02/02/14 10:04, Jason St. John wrote:
The change log prototype should be distribution determined.
Signed-off-by: Jason St. John <jstjohn@purdue.edu> --- This is a resubmission based on Allan's feedback here: https://mailman.archlinux.org/pipermail/pacman-dev/2014-January/018651.html
'make check' failure: make[1]: *** No rule to make target 'proto/ChangeLog.proto', needed by 'all-am'. Stop. Makefile:923: recipe for target 'check-recursive' failed make: *** [check-recursive] Error 1 Check "make dist" works too...
doc/PKGBUILD.5.txt | 1 + proto/ChangeLog.proto | 16 ---------------- 2 files changed, 1 insertion(+), 16 deletions(-) delete mode 100644 proto/ChangeLog.proto
diff --git a/doc/PKGBUILD.5.txt b/doc/PKGBUILD.5.txt index 6c5ef84..0638942 100644 --- a/doc/PKGBUILD.5.txt +++ b/doc/PKGBUILD.5.txt @@ -102,6 +102,7 @@ below).
*changelog*:: Specifies a changelog file that is to be included in the package. + The changelog file should end in a single newline. This file should reside in the same directory as the PKGBUILD and will be copied into the package by makepkg. It does not need to be included in the source array (e.g., `changelog=$pkgname.changelog`). diff --git a/proto/ChangeLog.proto b/proto/ChangeLog.proto deleted file mode 100644 index 87e86e7..0000000 --- a/proto/ChangeLog.proto +++ /dev/null @@ -1,16 +0,0 @@ -2007-12-01 Your Name <youremail@domain.com> - - * pkgver-pkgrel : - new upstream release. - Reason we changed stuff. - Another reason we changed stuff. - - * gcc-4.1.patch : - Removed, no longer needed. - -2007-11-01 Your Name <youremail@domain.com> - - * 1.0-5 : - added ChangeLog. - the last line should end with just one newline. - you can cat the file to check it displays fine.
participants (2)
-
Allan McRae
-
Jason St. John