Hi, i think man2html code could be removed to make build/configure scripts cleaner. Any objections? Jürgen
On 2/22/07, Jürgen Hötzel <juergen@hoetzel.info> wrote:
Hi,
i think man2html code could be removed to make build/configure scripts cleaner. Any objections?
Perhaps it should be made into a target instead? That way it doesn't need to be in configure, but is still available. It should be moved to the base Makefile.am as a target called "make man2html" (or maybe just keep it in the doc directory exclusively). I'm sure it can be cleaned up a decent amount, especially if one uses the $(man_MANS) variable that is already there to write a more correct target. On a side note, I moved some of the previously defined targets to ones with a "-local" extension today, that is the recommended/required way of doing automake stuff. This means that executing "make check" will run both the automake internal check, and then tack on your check-local target. This shouldn't be required with the above, however. -Dan
On Thu, Feb 22, 2007 at 08:13:12PM -0500, Dan McGee wrote:
On 2/22/07, Jürgen Hötzel <juergen@hoetzel.info> wrote:
Hi,
i think man2html code could be removed to make build/configure scripts cleaner. Any objections?
Perhaps it should be made into a target instead? That way it doesn't need to be in configure, but is still available. It should be moved to the base Makefile.am as a target called "make man2html" (or maybe just keep it in the doc directory exclusively). I'm sure it can be cleaned up a decent amount, especially if one uses the $(man_MANS) variable that is already there to write a more correct target.
The reason for removing is the same as with the auto-generated swig bindings. Both don't need the source package and can be generated from an installed pacman binary package. Currently the generated html aren't included by an automake conditional in as EXTRA_DIST. So I'm sure nobody will miss it. BTW: I think the only use for them is: http://www.archlinux.org/pacman/pacman.8.html ;-) Jürgen
On 2/23/07, Jürgen Hötzel <juergen@hoetzel.info> wrote:
On Thu, Feb 22, 2007 at 08:13:12PM -0500, Dan McGee wrote:
On 2/22/07, Jürgen Hötzel <juergen@hoetzel.info> wrote:
Hi,
i think man2html code could be removed to make build/configure scripts cleaner. Any objections?
Perhaps it should be made into a target instead? That way it doesn't need to be in configure, but is still available. It should be moved to the base Makefile.am as a target called "make man2html" (or maybe just keep it in the doc directory exclusively). I'm sure it can be cleaned up a decent amount, especially if one uses the $(man_MANS) variable that is already there to write a more correct target.
The reason for removing is the same as with the auto-generated swig bindings. Both don't need the source package and can be generated from an installed pacman binary package.
Currently the generated html aren't included by an automake conditional in as EXTRA_DIST. So I'm sure nobody will miss it. BTW: I think the only use for them is: http://www.archlinux.org/pacman/pacman.8.html ;-)
Jürgen
Yeah, I agree they don't serve much use, but is the new makepkg target I added much of a hassle? I don't want them to be included in EXTRA_DIST because they can be generated by the end-user if they want. -Dan
On Fri, Feb 23, 2007 at 01:00:39PM -0500, Dan McGee wrote:
On 2/23/07, Jürgen Hötzel <juergen@hoetzel.info> wrote:
On Thu, Feb 22, 2007 at 08:13:12PM -0500, Dan McGee wrote:
On 2/22/07, Jürgen Hötzel <juergen@hoetzel.info> wrote:
Hi,
i think man2html code could be removed to make build/configure scripts cleaner. Any objections?
Perhaps it should be made into a target instead? That way it doesn't need to be in configure, but is still available. It should be moved to the base Makefile.am as a target called "make man2html" (or maybe just keep it in the doc directory exclusively). I'm sure it can be cleaned up a decent amount, especially if one uses the $(man_MANS) variable that is already there to write a more correct target.
The reason for removing is the same as with the auto-generated swig bindings. Both don't need the source package and can be generated from an installed pacman binary package.
Currently the generated html aren't included by an automake conditional in as EXTRA_DIST. So I'm sure nobody will miss it. BTW: I think the only use for them is: http://www.archlinux.org/pacman/pacman.8.html ;-)
Jürgen
Yeah, I agree they don't serve much use, but is the new makepkg target I added much of a hassle? I don't want them to be included in EXTRA_DIST because they can be generated by the end-user if they want.
So you have to create an own automake target and thus moving away from standard compliant GNU Makefiles. Then i would prefer a the solution using automake conditionals. I think both solutions are not worth it. Jürgen
participants (2)
-
Dan McGee
-
Jürgen Hötzel