[pacman-dev] [PATCH] Print repo being search for replaces in debug output
Given the message is repeated for each repo, it is a good idea to print the repo name in the output. Signed-off-by: Allan McRae <allan@archlinux.org> --- Or... we could remove that output altogether. I'm not sure it is really useful. lib/libalpm/sync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 66f7ed1..c853d4d 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -125,7 +125,8 @@ static alpm_list_t *check_replacers(alpm_handle_t *handle, alpm_pkg_t *lpkg, alpm_list_t *replacers = NULL; alpm_list_t *k; _alpm_log(handle, ALPM_LOG_DEBUG, - "searching for replacements for %s\n", lpkg->name); + "searching for replacements for %s in the [%s] repo\n", + lpkg->name, sdb->treename); for(k = _alpm_db_get_pkgcache(sdb); k; k = k->next) { int found = 0; alpm_pkg_t *spkg = k->data; -- 1.7.11.4
On Sun, Aug 5, 2012 at 5:09 AM, Allan McRae <allan@archlinux.org> wrote:
Given the message is repeated for each repo, it is a good idea to print the repo name in the output.
Signed-off-by: Allan McRae <allan@archlinux.org> ---
Or... we could remove that output altogether. I'm not sure it is really useful. Looks like both you and Dave did something like this- I grabbed yours and ended up tweaking it to look more like Dave's. Either way, better message now.
lib/libalpm/sync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 66f7ed1..c853d4d 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -125,7 +125,8 @@ static alpm_list_t *check_replacers(alpm_handle_t *handle, alpm_pkg_t *lpkg, alpm_list_t *replacers = NULL; alpm_list_t *k; _alpm_log(handle, ALPM_LOG_DEBUG, - "searching for replacements for %s\n", lpkg->name); + "searching for replacements for %s in the [%s] repo\n", + lpkg->name, sdb->treename); for(k = _alpm_db_get_pkgcache(sdb); k; k = k->next) { int found = 0; alpm_pkg_t *spkg = k->data; -- 1.7.11.4
participants (2)
-
Allan McRae
-
Dan McGee