[pacman-dev] [PATCH] Add VerbostListInfo Option
Attached is a patch to add the VerboseListInfo option. This option takes the place of ShowSize as well as ShowOldVersion, which was submitted as a patch but never committed. During searches, the size of the packages are still shown, just like when ShowSize was enabled. During upgrades, the size as well as the old package version are shown in a formatted output with each package having its own line as well as each element (version, size) having its own column. The way I decided to handle printing in this format was to create a new function, formatted_list_display. This function accepts the title of the list, a list of rows with columns separated by commas, and a list of formats for the rows with the formats for each column also separated by commas. Example, the rows passed to the function would look like: lib32-gcc-libs,New,4.2.2-2,1.05 MB audacious-player,1.3.2-4,1.4.0-1,1.07 MB and the format would be something like: %-19s,%-10s,%-10s,%7s The function splits the row up by column and prints each columns with the widths specified. Since the columns are separated by commas, you can't have any commas in the rows or the format, so we may want to discuss another way to handle the formatted output. Other than the possible comma problem, this function should be usable anywhere you want to display a table of information. Example Output: --- $ src/pacman/pacman.static -Qu Checking for package upgrades... warning: xpdf: forcing upgrade to version 3.02_pl2-1 Remove: lib32-gcc Total Removed Size: 0.00 MB Targets: lib32-gcc-libs New 4.2.2-2 1.05 MB audacious-player 1.3.2-4 1.4.0-1 1.07 MB audacious-plugins 1.3.5-5.1 1.4.0-2 1.68 MB eclipse-pydev 1.3.9-1 1.3.10-1 3.39 MB fakeroot 1.7.1-3 1.8.4-1 0.06 MB glibc 2.7-4 2.7-6 10.78 MB glproto 1.4.8-1 1.4.9-1 0.02 MB hal-info 0.20071011-1 0.20071030-1 0.03 MB imagemagick 6.3.6.6-1 6.3.6.10-1 2.30 MB lib32-glibc 2.6.1-2 2.7-5 3.64 MB libarchive 2.2.6-2 2.4.0-1 0.32 MB libgphoto2 2.3.1-3 2.4.0-2 1.36 MB libmcs 0.4.1-2 0.6.0-1 0.02 MB libsamplerate 0.1.2-3 0.1.2-4 0.20 MB lincity-ng 1.1.1-1 1.1.2-1 29.16 MB lm_sensors 2.10.5-1 2.10.5-2 0.32 MB tcl 8.4.16-1 8.4.16-2 1.63 MB tk 8.4.16-1 8.4.16-2 1.40 MB ttf-dejavu 2.20-1 2.21-1 3.79 MB xf86-video-ati 6.7.195-1 6.7.195-3 3.67 MB xorg-server 1.4-4 1.4-5 7.25 MB xpdf 3.02_pl1-1 3.02_pl2-1 0.49 MB Total Download Size: 73.64 MB Total Installed Size: 91.08 MB --- Justin Lampley
This is just a little update so it displays None if there was nothing passed to formatted_list_display. Justin
On Nov 14, 2007 11:27 PM, Justin Lampley <jrlampley@gmail.com> wrote:
This is just a little update so it displays None if there was nothing passed to formatted_list_display.
I'll apply this tomorrow - I have to do some finagling because I also merged the --quiet patch, but that's my job, not yours 8) So Dan, don't just the gun here unless you want to snag my working branch first
On Nov 15, 2007 1:48 AM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Nov 14, 2007 11:27 PM, Justin Lampley <jrlampley@gmail.com> wrote:
This is just a little update so it displays None if there was nothing passed to formatted_list_display.
I'll apply this tomorrow - I have to do some finagling because I also merged the --quiet patch, but that's my job, not yours 8)
So Dan, don't just the gun here unless you want to snag my working branch first
Sounds good, I'll let you take this one, I'll look it over sometime today just to make sure I don't see anything weird. Be sure that when you test, you test our original output too- we don't want that to get all screwed up. -Dan
participants (3)
-
Aaron Griffin
-
Dan McGee
-
Justin Lampley