[pacman-dev] [PATCH] valgrind.supp: suppress leak in gpgme_get_key
Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> --- valgrind.supp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/valgrind.supp b/valgrind.supp index 46edccf..55effa9 100644 --- a/valgrind.supp +++ b/valgrind.supp @@ -64,6 +64,13 @@ fun:gpgme_get_engine_info } { + gpgme-static-get-key + Memcheck:Leak + fun:calloc + ... + fun:gpgme_get_key +} +{ gpgme-static-set-engine-info Memcheck:Leak fun:malloc -- 1.8.5.2
On 04/01/14 05:43, Andrew Gregory wrote:
Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com>
Ack
On Fri, Jan 3, 2014 at 8:43 PM, Andrew Gregory <andrew.gregory.8@gmail.com> wrote:
Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> --- valgrind.supp | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/valgrind.supp b/valgrind.supp index 46edccf..55effa9 100644 --- a/valgrind.supp +++ b/valgrind.supp @@ -64,6 +64,13 @@ fun:gpgme_get_engine_info } { + gpgme-static-get-key + Memcheck:Leak + fun:calloc + ... + fun:gpgme_get_key +} +{ gpgme-static-set-engine-info Memcheck:Leak fun:malloc -- 1.8.5.2
I don't understand the reasoning behind this. How is this not a proper bug which needs to be treated by upstream? cheers? mar77i
On Mon, Jan 6, 2014 at 6:40 AM, Martti Kühne <mysatyre@gmail.com> wrote:
On Fri, Jan 3, 2014 at 8:43 PM, Andrew Gregory <andrew.gregory.8@gmail.com> wrote:
Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> --- valgrind.supp | 7 +++++++ 1 file changed, 7 insertions(+)
I don't understand the reasoning behind this. How is this not a proper bug which needs to be treated by upstream?
This isn't a one-off thing, it is just adding another function to the long list we already had. See this for the start of things: commit 1187edb38c5ba42d27fd1de8e97aab658049367f Author: Dan McGee <dan@archlinux.org> Date: Tue Jun 14 10:32:35 2011 -0500 valgrind.supp: add known leaks from GPGME Thank you too, GPGME, for these. Why don't you provide a way to clean up your static variable mess?
participants (4)
-
Allan McRae
-
Andrew Gregory
-
Dan McGee
-
Martti Kühne