[pacman-dev] PKGBUILD and install file drafts for release
Attached. I'd appreciate people looking them over and offering comments and/or fixes. -Dan
On Dec 19, 2007 11:57 PM, Dan McGee <dpmcgee@gmail.com> wrote:
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
Two questions/comments: a) Why is only /etc/pacman.d/core backed up, shouldn't we, at least for the first release, backup all files? b) brace expansion in backup array on abs PKGBUILD... something I didn't think about, I'll have to mention this to eliott (he's re-doing a portion of the DB scripts which involves PKGBUILD parsing)
On Dec 19, 2007 11:57 PM, Dan McGee <dpmcgee@gmail.com> wrote:
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
Minor comment regarding the REQUIREDBY sed stuff - perhaps echo the final status, just to be clear? if all ${PIPESTATUS[@]} == 0, everything wins, else, potential DB issues
On Dec 20, 2007 12:19 AM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Dec 19, 2007 11:57 PM, Dan McGee <dpmcgee@gmail.com> wrote:
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
Minor comment regarding the REQUIREDBY sed stuff - perhaps echo the final status, just to be clear? if all ${PIPESTATUS[@]} == 0, everything wins, else, potential DB issues
PIPESTATUS is bash specific, not that it matters. Can you just write actual code here instead of half psuedocode? -Dan
On Dec 21, 2007 8:03 PM, Dan McGee <dpmcgee@gmail.com> wrote:
On Dec 20, 2007 12:19 AM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Dec 19, 2007 11:57 PM, Dan McGee <dpmcgee@gmail.com> wrote:
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
Minor comment regarding the REQUIREDBY sed stuff - perhaps echo the final status, just to be clear? if all ${PIPESTATUS[@]} == 0, everything wins, else, potential DB issues
PIPESTATUS is bash specific, not that it matters.
Can you just write actual code here instead of half psuedocode?
There was no code because it wasn't a "do this" comment, it was a "what do you think of this" comment. A response of "sounds good, but PIPESTATUS is bash specific" etc, etc, would have been met with code. I actually wasn't expecting hostility to the above comment because it was, after all, a comment. If this is the case, I retract it
On Dec 29, 2007 3:56 AM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Dec 21, 2007 8:03 PM, Dan McGee <dpmcgee@gmail.com> wrote:
On Dec 20, 2007 12:19 AM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Dec 19, 2007 11:57 PM, Dan McGee <dpmcgee@gmail.com> wrote:
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
Minor comment regarding the REQUIREDBY sed stuff - perhaps echo the final status, just to be clear? if all ${PIPESTATUS[@]} == 0, everything wins, else, potential DB issues
PIPESTATUS is bash specific, not that it matters.
Can you just write actual code here instead of half psuedocode?
There was no code because it wasn't a "do this" comment, it was a "what do you think of this" comment. A response of "sounds good, but PIPESTATUS is bash specific" etc, etc, would have been met with code.
I actually wasn't expecting hostility to the above comment because it was, after all, a comment. If this is the case, I retract it
It wasn't meant to be hostile at all if I came across as that, sorry. I just don't have any idea how to actually do it, so I was looking for some help. I think it is a good idea. -Dan
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
-Dan
Well, as I see "make install" doesn't install contrib files (my favourite re-pacman for example <- which is a bit outdated now). Is this OK? Bye
On Thu, Dec 20, 2007 at 03:39:00PM +0100, Nagy Gabor wrote:
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
-Dan
Well, as I see "make install" doesn't install contrib files (my favourite re-pacman for example <- which is a bit outdated now). Is this OK?
This could cause conflicts if the user has already copied the files over from previous releases. With that being said, I would like contrib files to be installed as well. Here's some install lines that may or not be useful if this is decided: echo "au BufRead,BufNewFile PKGBUILD set ft=pkgbuild" > $startdir/pkg/usr/share/vim/ftdetect/pkgbuild.vim install -D -m644 contrib/PKGBUILD.vim $startdir/pkg/usr/share/vim/syntax/pkgbuild.vim install -D -m644 contrib/bash_completion $startdir/pkg/etc/bash_completion.d/pacman install -D -m644 contrib/zsh_completion $startdir/pkg/usr/share/zsh/site-functions/_pacman install -D -m755 contrib/pacdiff $startdir/pkg/usr/bin/pacdiff install -D -m755 contrib/pacsearch $startdir/pkg/usr/bin/pacsearch install -D -m755 contrib/re-pacman $startdir/pkg/usr/bin/re-pacman
On Dec 21, 2007 5:06 PM, Nathan Jones <nathanj@insightbb.com> wrote:
On Thu, Dec 20, 2007 at 03:39:00PM +0100, Nagy Gabor wrote:
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
-Dan
Well, as I see "make install" doesn't install contrib files (my favourite re-pacman for example <- which is a bit outdated now). Is this OK?
This could cause conflicts if the user has already copied the files over from previous releases. With that being said, I would like contrib files to be installed as well. Here's some install lines that may or not be useful if this is decided:
echo "au BufRead,BufNewFile PKGBUILD set ft=pkgbuild" > $startdir/pkg/usr/share/vim/ftdetect/pkgbuild.vim install -D -m644 contrib/PKGBUILD.vim $startdir/pkg/usr/share/vim/syntax/pkgbuild.vim
install -D -m644 contrib/bash_completion $startdir/pkg/etc/bash_completion.d/pacman install -D -m644 contrib/zsh_completion $startdir/pkg/usr/share/zsh/site-functions/_pacman
install -D -m755 contrib/pacdiff $startdir/pkg/usr/bin/pacdiff install -D -m755 contrib/pacsearch $startdir/pkg/usr/bin/pacsearch install -D -m755 contrib/re-pacman $startdir/pkg/usr/bin/re-pacman
Although I think it would be good to install a lot of these, I'm going to hold off for at least 3.1.0. However, they are included in the tarball so this can change with even a pkgrel bump. The proto files are going to be installed however, as well as the two completion files. If there is more interest, I'd be glad to install the rest. Maybe a forum post would suffice to gauge it, if anyone wants to do that. -Dan
2008/1/10, Dan McGee <dpmcgee@gmail.com>:
On Dec 21, 2007 5:06 PM, Nathan Jones <nathanj@insightbb.com> wrote:
On Thu, Dec 20, 2007 at 03:39:00PM +0100, Nagy Gabor wrote:
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
-Dan
Well, as I see "make install" doesn't install contrib files (my favourite re-pacman for example <- which is a bit outdated now). Is this OK?
This could cause conflicts if the user has already copied the files over from previous releases. With that being said, I would like contrib files to be installed as well. Here's some install lines that may or not be useful if this is decided:
echo "au BufRead,BufNewFile PKGBUILD set ft=pkgbuild" > $startdir/pkg/usr/share/vim/ftdetect/pkgbuild.vim install -D -m644 contrib/PKGBUILD.vim $startdir/pkg/usr/share/vim/syntax/pkgbuild.vim
install -D -m644 contrib/bash_completion $startdir/pkg/etc/bash_completion.d/pacman install -D -m644 contrib/zsh_completion $startdir/pkg/usr/share/zsh/site-functions/_pacman
install -D -m755 contrib/pacdiff $startdir/pkg/usr/bin/pacdiff install -D -m755 contrib/pacsearch $startdir/pkg/usr/bin/pacsearch install -D -m755 contrib/re-pacman $startdir/pkg/usr/bin/re-pacman
Although I think it would be good to install a lot of these, I'm going to hold off for at least 3.1.0. However, they are included in the tarball so this can change with even a pkgrel bump.
The proto files are going to be installed however, as well as the two completion files.
If there is more interest, I'd be glad to install the rest. Maybe a forum post would suffice to gauge it, if anyone wants to do that.
At least me would love to see pacdiff/pacsearch/re-pacman in /usr/bin in one of next releases. And I guess [g]vim (and KVim KPart) users would love to get syntax highliting files as well. -- Roman Kyrylych (Роман Кирилич)
At least me would love to see pacdiff/pacsearch/re-pacman in /usr/bin in one of next releases. And I guess [g]vim (and KVim KPart) users would love to get syntax highliting files as well. +1 But imho we should review them first (re-pacman needs some updates). Bye
---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/
On Dec 20, 2007 12:57 AM, Dan McGee <dpmcgee@gmail.com> wrote:
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
Quick comment about the .install. In most places, your messages follow an echo ">>> message" format, except in _resetbackups, which uses echo ":: message" - maybe change one or the other for consistency? And yeah, why is /etc/pacman.d/core still in the backup array? Oversight?
On Dec 20, 2007 8:51 AM, Travis Willard <travis@archlinux.org> wrote:
On Dec 20, 2007 12:57 AM, Dan McGee <dpmcgee@gmail.com> wrote:
Attached. I'd appreciate people looking them over and offering comments and/or fixes.
Quick comment about the .install. In most places, your messages follow an echo ">>> message" format, except in _resetbackups, which uses echo ":: message" - maybe change one or the other for consistency?
And yeah, why is /etc/pacman.d/core still in the backup array? Oversight?
# keep backup of pacman.d/core just so it isn't wiped and people can merge backup=(etc/pacman.conf etc/makepkg.conf etc/abs/abs.conf etc/pacman.d/core etc/pacman.d/mirrorlist) Did you read the comments before sending that email, or was it really unclear? If it was, then I can clarify that comment. -Dan
On Dec 20, 2007 10:37 AM, Dan McGee <dpmcgee@gmail.com> wrote:
On Dec 20, 2007 8:51 AM, Travis Willard <travis@archlinux.org> wrote:
And yeah, why is /etc/pacman.d/core still in the backup array? Oversight?
# keep backup of pacman.d/core just so it isn't wiped and people can merge backup=(etc/pacman.conf etc/makepkg.conf etc/abs/abs.conf etc/pacman.d/core etc/pacman.d/mirrorlist)
Did you read the comments before sending that email, or was it really unclear? If it was, then I can clarify that comment.
*facepalm* Wow - I totally missed that comment - yeah, ignore that part of my email. T.T
On Dec 20, 2007 9:46 AM, Travis Willard <travis@archlinux.org> wrote:
On Dec 20, 2007 10:37 AM, Dan McGee <dpmcgee@gmail.com> wrote:
On Dec 20, 2007 8:51 AM, Travis Willard <travis@archlinux.org> wrote:
And yeah, why is /etc/pacman.d/core still in the backup array? Oversight?
# keep backup of pacman.d/core just so it isn't wiped and people can merge backup=(etc/pacman.conf etc/makepkg.conf etc/abs/abs.conf etc/pacman.d/core etc/pacman.d/mirrorlist)
Did you read the comments before sending that email, or was it really unclear? If it was, then I can clarify that comment.
*facepalm* Wow - I totally missed that comment - yeah, ignore that part of my email. T.T
syntax highlighting? heh Dan, if you only backed up core on purpose, could you clarify the comment that way - I don't know if it was intentional or not.
participants (6)
-
Aaron Griffin
-
Dan McGee
-
Nagy Gabor
-
Nathan Jones
-
Roman Kyrylych
-
Travis Willard