On 7/30/19 12:57 AM, Austin Lund wrote:

There are a handful of packages that force !strip (e.g. glibc, firefox, bash).

The Firefox package is apparently not supposed to use pacman-compatible debugging symbols at all. The symbols are separately handled, then uploaded to Mozilla; I guess you're supposed to use Mozilla's tracing services. glibc is forcing !strip because it needs to manually strip and thereby exclude a few files from being stripped. I have a better solution in aur/glibc-git for this which could probably be used. The bash package, last I checked, was stripped normally.

The current prefix rewriting to /usr/src/debug essentially ensures a symbol lookup failure when compiling with debug enabled for these packages (unless you build in /usr/src/debug). The gcc substitute path can only handle one FROM path hence you cannot simultaneously get symbols for these packages.

Good point.

Would a relative path for the debug !strip case make more sense? In that instance gdb could be configured using "set directories" to resolve to the build sources should they not be purged.

All three possible approaches (do nothing, do your initial suggestion, do relative paths) are rather subjective. I merely point out perspectives. It's possibly worth noting that even if the paths are still mapped to remove $srcdir, it's still encoded as "builddir" in the .BUILDINFO file. You can make the binaries directory-agnostic, but not the overall package. ... I guess if we're going to make this behavior conditional at all, simply disabling it entirely as your initial patch does would be the simplest approach and also works OOTB for the debugging case (assuming the build directory is still extant). -- Eli Schwartz Bug Wrangler and Trusted User

On Tue, 30 Jul 2019 at 15:33, Eli Schwartz wrote:

...

The current prefix rewriting to /usr/src/debug essentially ensures a symbol lookup failure when compiling with debug enabled for these packages (unless you build in /usr/src/debug). The gcc substitute path can only handle one FROM path hence you cannot simultaneously get symbols for these packages.

Good point.

...

Would a relative path for the debug !strip case make more sense? In that instance gdb could be configured using "set directories" to resolve to the build sources should they not be purged.

I guess if we're going to make this behavior conditional at all, simply disabling it entirely as your initial patch does would be the simplest approach and also works OOTB for the debugging case (assuming the build directory is still extant).

I had a play around with some of the options. The way gdb handles the lookup of sources and symbols is somewhat strange. The only way I have managed to get it to work without having a reference to the original build directory is to change the prefix to something that is easily searchable and be substituted on a per-source-tree basis. Unlike the recommendation in the gcc manual page, this is _not_ "." as you can't point different trees to different directories. For the "debug" and "!strip" case, I used: DEBUG_CFLAGS+=" -fdebug-prefix-map=$srcdir=arch-${pkgname}" That seemed to work OK as I could add a set subsitiute-path into the build sources for each package which was "debug" and "!strip".