[pacman-dev] [PATCH] libalpm: sync_prepare: re-order w.r.t. dependencies
hi it seems that this "re-order w.r.t. dependencies" thing is currently only done at -A/-U and -R, but not -S http://frugalware.org/~vmiklos/patches/libpacman-proposed/sync_prepare_deps.... this patch implements this NOTE: as the dependsonly patch haven't been reviewed yet and this patch "depends" on that patch, this is a "backported" one. the original patch is available from the darcs repo, which contains all of our (Frugalware) patches: http://darcs.frugalware.org/darcsweb/darcsweb.cgi?r=pacman;a=darcs_commitdif... udv / greetings, VMiklos -- Developer of Frugalware Linux, to make things frugal - http://frugalware.org
Hi, On Sat, Dec 17, 2005 at 01:33:38AM +0100, VMiklos wrote:
it seems that this "re-order w.r.t. dependencies" thing is currently only done at -A/-U and -R, but not -S
I don't think it's necessary with -S, because of the way resolvedeps() processes targets. Or am I missing something? Also, I think there is some leakage in there. Some list entries left behind due to the reassigning of trans->packages and the sortbydeps() call. - J ps: Happy Holidays to all pacman hackers! Don't work too hard over the holidays. :)
On Sun, Dec 25, 2005 at 04:21:00PM -0800, Judd Vinet <jvinet@zeroflux.org> wrote:
I don't think it's necessary with -S, because of the way resolvedeps() processes targets. Or am I missing something?
resolvedeps will not add the dependency if it's already in the target list (see libalpm/deps.c:629). so if you do a pacman -S bash glibc, the order will be bash glibc instead of glibc bash
Also, I think there is some leakage in there. Some list entries left behind due to the reassigning of trans->packages and the sortbydeps() call.
hm, yes, i forgot to FREELISTPTR() trans->packages. here is an updated patch: http://frugalware.org/~vmiklos/patches/libpacman-proposed/sync_prepare_deps2... sortbydeps() will modify the list in place. how could this cause a memleak?
ps: Happy Holidays to all pacman hackers! Don't work too hard over the holidays. :)
same to you! btw it's over now ;) udv / greetings, VMiklos -- Developer of Frugalware Linux, to make things frugal - http://frugalware.org
participants (2)
-
Judd Vinet
-
VMiklos