[pacman-dev] [PATCH] Fix pointer declarations to be globally consistent
From: Micah Saint Germain <micahsg@google.com> Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user. Expected format of a pointer declaration: `typename *varname` Signed-off-by: Micah Saint Germain <micahsg@google.com> --- src/pacman/callback.h | 2 +- src/pacman/pacman.c | 10 +++++----- src/pacman/sync.c | 2 +- src/util/pactree.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/pacman/callback.h b/src/pacman/callback.h index 5480c73..498536f 100644 --- a/src/pacman/callback.h +++ b/src/pacman/callback.h @@ -28,7 +28,7 @@ void cb_event(alpm_event_t *event); /* callback to handle questions from libalpm (yes/no) */ -void cb_question(alpm_question_t* question); +void cb_question(alpm_question_t *question); /* callback to handle display of progress */ void cb_progress(alpm_progress_t event, const char *pkgname, int percent, diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 6161048..f43105a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -97,11 +97,11 @@ static void usage(int op, const char * const myname) alpm_list_t *list = NULL, *i; /* prefetch some strings for usage below, which moves a lot of calls * out of gettext. */ - char const * const str_opt = _("options"); - char const * const str_file = _("file(s)"); - char const * const str_pkg = _("package(s)"); - char const * const str_usg = _("usage"); - char const * const str_opr = _("operation"); + char const *const str_opt = _("options"); + char const *const str_file = _("file(s)"); + char const *const str_pkg = _("package(s)"); + char const *const str_usg = _("usage"); + char const *const str_opr = _("operation"); /* please limit your strings to 80 characters in width */ if(op == PM_OP_MAIN) { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 4609186..215497f 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -230,7 +230,7 @@ static int sync_cleancache(int level) } if(level <= 1) { - static const char * const glob_skips[] = { + static const char *const glob_skips[] = { /* skip signature files - they are removed with their package file */ "*.sig", /* skip package database within the cache directory */ diff --git a/src/util/pactree.c b/src/util/pactree.c index 5c76542..14579e4 100644 --- a/src/util/pactree.c +++ b/src/util/pactree.c @@ -339,7 +339,7 @@ static void cleanup(void) static void print_text(const char *pkg, const char *provision, tdepth *depth, int last) { - const char* tip = ""; + const char *tip = ""; int level = 1; if(!pkg && !provision) { /* not much we can do */ -- 2.1.0
On Fri, Dec 12, 2014 at 12:03:18AM -0500, Micah Saint Germain wrote:
From: Micah Saint Germain <micahsg@google.com>
Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user.
Expected format of a pointer declaration: `typename *varname`
Signed-off-by: Micah Saint Germain <micahsg@google.com> ---
Hi, You mentioned on IRC that you were confused about your work email address being preserved (with the implication that you did not want this). This is due to your local git configuration, i.e.: git config --global --get-regexp ^user\\. I'd strongly advise you to separate your professional work environment from your personal work environment. d
src/pacman/callback.h | 2 +- src/pacman/pacman.c | 10 +++++----- src/pacman/sync.c | 2 +- src/util/pactree.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/pacman/callback.h b/src/pacman/callback.h index 5480c73..498536f 100644 --- a/src/pacman/callback.h +++ b/src/pacman/callback.h @@ -28,7 +28,7 @@ void cb_event(alpm_event_t *event);
/* callback to handle questions from libalpm (yes/no) */ -void cb_question(alpm_question_t* question); +void cb_question(alpm_question_t *question);
/* callback to handle display of progress */ void cb_progress(alpm_progress_t event, const char *pkgname, int percent, diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 6161048..f43105a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -97,11 +97,11 @@ static void usage(int op, const char * const myname) alpm_list_t *list = NULL, *i; /* prefetch some strings for usage below, which moves a lot of calls * out of gettext. */ - char const * const str_opt = _("options"); - char const * const str_file = _("file(s)"); - char const * const str_pkg = _("package(s)"); - char const * const str_usg = _("usage"); - char const * const str_opr = _("operation"); + char const *const str_opt = _("options"); + char const *const str_file = _("file(s)"); + char const *const str_pkg = _("package(s)"); + char const *const str_usg = _("usage"); + char const *const str_opr = _("operation");
/* please limit your strings to 80 characters in width */ if(op == PM_OP_MAIN) { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 4609186..215497f 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -230,7 +230,7 @@ static int sync_cleancache(int level) }
if(level <= 1) { - static const char * const glob_skips[] = { + static const char *const glob_skips[] = { /* skip signature files - they are removed with their package file */ "*.sig", /* skip package database within the cache directory */ diff --git a/src/util/pactree.c b/src/util/pactree.c index 5c76542..14579e4 100644 --- a/src/util/pactree.c +++ b/src/util/pactree.c @@ -339,7 +339,7 @@ static void cleanup(void) static void print_text(const char *pkg, const char *provision, tdepth *depth, int last) { - const char* tip = ""; + const char *tip = ""; int level = 1; if(!pkg && !provision) { /* not much we can do */ -- 2.1.0
On 12/12/14 23:51, Dave Reisner wrote:
On Fri, Dec 12, 2014 at 12:03:18AM -0500, Micah Saint Germain wrote:
From: Micah Saint Germain <micahsg@google.com>
Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user.
Expected format of a pointer declaration: `typename *varname`
Signed-off-by: Micah Saint Germain <micahsg@google.com> ---
Hi,
You mentioned on IRC that you were confused about your work email address being preserved (with the implication that you did not want this). This is due to your local git configuration, i.e.:
git config --global --get-regexp ^user\\.
I'd strongly advise you to separate your professional work environment from your personal work environment.
Am I waiting on a version of this patch that uses a single email address? Allan
Allan, I've resubmitted the patch. - Micah On Fri, Dec 12, 2014 at 08:51:30AM -0500, Dave Reisner wrote:
On Fri, Dec 12, 2014 at 12:03:18AM -0500, Micah Saint Germain wrote:
From: Micah Saint Germain <micahsg@google.com>
Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user.
Expected format of a pointer declaration: `typename *varname`
Signed-off-by: Micah Saint Germain <micahsg@google.com> ---
Hi,
You mentioned on IRC that you were confused about your work email address being preserved (with the implication that you did not want this). This is due to your local git configuration, i.e.:
git config --global --get-regexp ^user\\.
I'd strongly advise you to separate your professional work environment from your personal work environment.
d
src/pacman/callback.h | 2 +- src/pacman/pacman.c | 10 +++++----- src/pacman/sync.c | 2 +- src/util/pactree.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/pacman/callback.h b/src/pacman/callback.h index 5480c73..498536f 100644 --- a/src/pacman/callback.h +++ b/src/pacman/callback.h @@ -28,7 +28,7 @@ void cb_event(alpm_event_t *event);
/* callback to handle questions from libalpm (yes/no) */ -void cb_question(alpm_question_t* question); +void cb_question(alpm_question_t *question);
/* callback to handle display of progress */ void cb_progress(alpm_progress_t event, const char *pkgname, int percent, diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 6161048..f43105a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -97,11 +97,11 @@ static void usage(int op, const char * const myname) alpm_list_t *list = NULL, *i; /* prefetch some strings for usage below, which moves a lot of calls * out of gettext. */ - char const * const str_opt = _("options"); - char const * const str_file = _("file(s)"); - char const * const str_pkg = _("package(s)"); - char const * const str_usg = _("usage"); - char const * const str_opr = _("operation"); + char const *const str_opt = _("options"); + char const *const str_file = _("file(s)"); + char const *const str_pkg = _("package(s)"); + char const *const str_usg = _("usage"); + char const *const str_opr = _("operation");
/* please limit your strings to 80 characters in width */ if(op == PM_OP_MAIN) { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 4609186..215497f 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -230,7 +230,7 @@ static int sync_cleancache(int level) }
if(level <= 1) { - static const char * const glob_skips[] = { + static const char *const glob_skips[] = { /* skip signature files - they are removed with their package file */ "*.sig", /* skip package database within the cache directory */ diff --git a/src/util/pactree.c b/src/util/pactree.c index 5c76542..14579e4 100644 --- a/src/util/pactree.c +++ b/src/util/pactree.c @@ -339,7 +339,7 @@ static void cleanup(void) static void print_text(const char *pkg, const char *provision, tdepth *depth, int last) { - const char* tip = ""; + const char *tip = ""; int level = 1; if(!pkg && !provision) { /* not much we can do */ -- 2.1.0
participants (4)
-
Allan McRae
-
Dave Reisner
-
Micah Saint Germain
-
micah＠lexme.org