[pacman-dev] [PATCH 1/2] unset executable bit on updpkgsums.sh.in
No other contrib script is executable. Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> --- The scripts in test/scripts are also inconsistent, but I'm not sure whether they should be executable or not. contrib/updpkgsums.sh.in | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 contrib/updpkgsums.sh.in diff --git a/contrib/updpkgsums.sh.in b/contrib/updpkgsums.sh.in old mode 100755 new mode 100644 -- 1.8.1.2
On 30/01/13 12:23, Andrew Gregory wrote:
No other contrib script is executable.
Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> ---
Ack.
The scripts in test/scripts are also inconsistent, but I'm not sure whether they should be executable or not.
Dave?
On Wed, Jan 30, 2013 at 10:33:52PM +1000, Allan McRae wrote:
On 30/01/13 12:23, Andrew Gregory wrote:
No other contrib script is executable.
Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> ---
Ack.
The scripts in test/scripts are also inconsistent, but I'm not sure whether they should be executable or not.
Dave?
I don't see any harm in making scripts in test/scripts executable. They're meant to be run, unlike the .sh.in files in contrib/ or scripts/.
On Wed, Jan 30, 2013 at 7:40 AM, Dave Reisner <d@falconindy.com> wrote:
On Wed, Jan 30, 2013 at 10:33:52PM +1000, Allan McRae wrote:
On 30/01/13 12:23, Andrew Gregory wrote:
No other contrib script is executable.
Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> ---
Ack.
The scripts in test/scripts are also inconsistent, but I'm not sure whether they should be executable or not.
Dave?
I don't see any harm in making scripts in test/scripts executable. They're meant to be run, unlike the .sh.in files in contrib/ or scripts/.
Agreed- the ones that are executable actually have __main__ methods (if Python) or are standalone bash scripts that don't need preprocessing. -Dan
participants (4)
-
Allan McRae
-
Andrew Gregory
-
Dan McGee
-
Dave Reisner