[pacman-dev] pacman-5.0:Should pkgver() and prepare() run when repackage?
I am using the pacman's latest master branch, when I run 'makepkg -R' to repackage packages, it will run pkgver() and prepare(), if there are some patch command in prepare(), it will fail. should pkgver() and prepare() run when repackage? This problem may be introduced by this commit: https://projects.archlinux.org/pacman.git/commit/?id=8454daa7feef14b660561f2... An ugly working patch is: diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 753621b..57302a0 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -2207,12 +2207,12 @@ elif (( !REPKG )); then extract_sources fi -if (( PKGVERFUNC )); then +if (( PKGVERFUNC && !REPKG )); then update_pkgver basever=$(get_full_version) check_build_status fi -if (( PREPAREFUNC )); then +if (( PREPAREFUNC && !REPKG )); then run_prepare fi
On 21/01, Zuyi Hu wrote:
I am using the pacman's latest master branch, when I run 'makepkg -R' to repackage packages, it will run pkgver() and prepare(), if there are some patch command in prepare(), it will fail. should pkgver() and prepare() run when repackage?
It does seem weird for the prepare function to be run. Though --noprepare should work as a workaround in the interim. -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 https://theos.kyriasis.com/~kyrias/
On 21/01/16 16:18, Johannes Löthberg wrote:
On 21/01, Zuyi Hu wrote:
I am using the pacman's latest master branch, when I run 'makepkg -R' to repackage packages, it will run pkgver() and prepare(), if there are some patch command in prepare(), it will fail. should pkgver() and prepare() run when repackage?
It does seem weird for the prepare function to be run. Though --noprepare should work as a workaround in the interim.
It is a bug - I will look at the patch soon. A
On 21/01/16 11:57, Zuyi Hu wrote:
I am using the pacman's latest master branch, when I run 'makepkg -R' to repackage packages, it will run pkgver() and prepare(), if there are some patch command in prepare(), it will fail. should pkgver() and prepare() run when repackage?
This problem may be introduced by this commit: https://projects.archlinux.org/pacman.git/commit/?id=8454daa7feef14b660561f2...
Thanks for the report. I have just posted a patch. Allan
participants (3)
-
Allan McRae
-
Johannes Löthberg
-
Zuyi Hu