[pacman-dev] [PATCH] libalpm: write {check, make}depends to localdb when installing package
It is a follow up of commits 0994893 and f9eb2aa. Signed-off-by: Denis Ollier <larchunix@gmail.com> --- lib/libalpm/be_local.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c index 5a03f257..a4b72776 100644 --- a/lib/libalpm/be_local.c +++ b/lib/libalpm/be_local.c @@ -1033,6 +1033,8 @@ int _alpm_local_db_write(alpm_db_t *db, alpm_pkg_t *info, int inforeq) write_deps(fp, "%REPLACES%", info->replaces); write_deps(fp, "%DEPENDS%", info->depends); write_deps(fp, "%OPTDEPENDS%", info->optdepends); + write_deps(fp, "%MAKEDEPENDS%", info->makedepends); + write_deps(fp, "%CHECKDEPENDS%", info->checkdepends); write_deps(fp, "%CONFLICTS%", info->conflicts); write_deps(fp, "%PROVIDES%", info->provides); -- 2.21.0
On 29/3/19 8:04 pm, Denis Ollier wrote:
It is a follow up of commits 0994893 and f9eb2aa.
I see no reason this is needed in the local database.
Signed-off-by: Denis Ollier <larchunix@gmail.com> --- lib/libalpm/be_local.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c index 5a03f257..a4b72776 100644 --- a/lib/libalpm/be_local.c +++ b/lib/libalpm/be_local.c @@ -1033,6 +1033,8 @@ int _alpm_local_db_write(alpm_db_t *db, alpm_pkg_t *info, int inforeq) write_deps(fp, "%REPLACES%", info->replaces); write_deps(fp, "%DEPENDS%", info->depends); write_deps(fp, "%OPTDEPENDS%", info->optdepends); + write_deps(fp, "%MAKEDEPENDS%", info->makedepends); + write_deps(fp, "%CHECKDEPENDS%", info->checkdepends); write_deps(fp, "%CONFLICTS%", info->conflicts); write_deps(fp, "%PROVIDES%", info->provides);
Le vendredi 29 mars 2019 à 20:16 +1000, Allan McRae a écrit :
On 29/3/19 8:04 pm, Denis Ollier wrote:
It is a follow up of commits 0994893 and f9eb2aa.
I see no reason this is needed in the local database.
Since _cache_get_makedepends() and _cache_get_checkdepends() functions have been added to be_local.c I just thought it could be better for them to return relevant values. Just drop this patch if you think it's not worth it.
Signed-off-by: Denis Ollier <larchunix@gmail.com> --- lib/libalpm/be_local.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c index 5a03f257..a4b72776 100644 --- a/lib/libalpm/be_local.c +++ b/lib/libalpm/be_local.c @@ -1033,6 +1033,8 @@ int _alpm_local_db_write(alpm_db_t *db, alpm_pkg_t *info, int inforeq) write_deps(fp, "%REPLACES%", info->replaces); write_deps(fp, "%DEPENDS%", info->depends); write_deps(fp, "%OPTDEPENDS%", info->optdepends); + write_deps(fp, "%MAKEDEPENDS%", info->makedepends); + write_deps(fp, "%CHECKDEPENDS%", info->checkdepends); write_deps(fp, "%CONFLICTS%", info->conflicts); write_deps(fp, "%PROVIDES%", info->provides);
participants (3)
-
Allan McRae
-
Denis Ollier
-
larchunix