[pacman-dev] Pacman split debug info symbol path

older
[pacman-dev] [PATCH 1/4] makepkg:...

Steven Noonan

29 Mar 2014 29 Mar '14

5:36 p.m.

Hi folks, I think the directory Pacman is using for the split-out debug symbols is incorrect. This appears to be needed: commit 61ed104abf95ac38e7d317c760807f308ea90555 Author: Steven Noonan Date: Wed Feb 12 05:44:16 2014 -0800 makepkg: use dash instead of underscore in /usr/lib/debug/.build-id Signed-off-by: Steven Noonan diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 027fcc3..7e663af 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1525,7 +1525,7 @@ strip_file() { # has this file already been stripped if [[ -n "$bid" ]]; then - if [[ -f "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" ]]; then + if [[ -f "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" ]]; then return fi elif [[ -f "$dbgdir/$binary.debug" ]]; then @@ -1546,15 +1546,15 @@ strip_file() { if [[ -n "$bid" ]]; then local target - mkdir -p "$dbgdir/.build_id/${bid:0:2}" + mkdir -p "$dbgdir/.build-id/${bid:0:2}" target="../../../../../${binary#./}" target="${target/..\/..\/usr\/lib\/}" target="${target/..\/usr\/}" - ln -s "$target" "$dbgdir/.build_id/${bid:0:2}/${bid:2}" + ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}" target="../../${binary#./}.debug" - ln -s "$target" "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" + ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" fi fi To justify this change, I can't find any tools that actually look in 'build_id' (with an underscore) when searching for symbols. For example, perf does this (lines 101, 105): https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/to... GDB also looks in '.build-id' (lines 83, 102): https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/build-... OProfile, same issue (lines 93, 104): http://sourceforge.net/p/oprofile/oprofile/ci/master/tree/libutil++/bfd_supp... I noticed tool breakage back when I submitted the kernel module split+debug patch, but kept the patch to myself because I figured I must have been missing the rationale for the difference, but I've been so far unable to find any. - Steven

Show replies by thread

Dave Reisner

29 Mar 29 Mar

5:41 p.m.

On Mar 29, 2014 1:36 PM, "Steven Noonan" wrote:

...

Hi folks,

I think the directory Pacman is using for the split-out debug symbols is incorrect. This appears to be needed:

Why do you think this? What are the symptoms you're seeing? I use debug packages all the time and they work as expected.

...

commit 61ed104abf95ac38e7d317c760807f308ea90555 Author: Steven Noonan Date: Wed Feb 12 05:44:16 2014 -0800

makepkg: use dash instead of underscore in /usr/lib/debug/.build-id

Signed-off-by: Steven Noonan

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 027fcc3..7e663af 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1525,7 +1525,7 @@ strip_file() {

# has this file already been stripped if [[ -n "$bid" ]]; then - if [[ -f "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" ]]; then + if [[ -f "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" ]]; then return fi elif [[ -f "$dbgdir/$binary.debug" ]]; then @@ -1546,15 +1546,15 @@ strip_file() {

if [[ -n "$bid" ]]; then local target - mkdir -p "$dbgdir/.build_id/${bid:0:2}" + mkdir -p "$dbgdir/.build-id/${bid:0:2}"

target="../../../../../${binary#./}" target="${target/..\/..\/usr\/lib\/}" target="${target/..\/usr\/}" - ln -s "$target"

"$dbgdir/.build_id/${bid:0:2}/${bid:2}"

...

+ ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}"

target="../../${binary#./}.debug" - ln -s "$target" "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" + ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" fi fi

To justify this change, I can't find any tools that actually look in 'build_id' (with an underscore) when searching for symbols.

For example, perf does this (lines 101, 105):

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/to...

...

GDB also looks in '.build-id' (lines 83, 102):

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/build-...

...

OProfile, same issue (lines 93, 104):

http://sourceforge.net/p/oprofile/oprofile/ci/master/tree/libutil++/bfd_supp...

...

I noticed tool breakage back when I submitted the kernel module split+debug patch, but kept the patch to myself because I figured I must have been missing the rationale for the difference, but I've been so far unable to find any.

- Steven

Steven Noonan

5:52 p.m.

On Sat, Mar 29, 2014 at 10:41 AM, Dave Reisner wrote:

...

On Mar 29, 2014 1:36 PM, "Steven Noonan" wrote:

...
Hi folks,

I think the directory Pacman is using for the split-out debug symbols is incorrect. This appears to be needed:

Why do you think this? What are the symptoms you're seeing? I use debug packages all the time and they work as expected.

I've seen tools complain they can't find debug symbols or simply not show any. What tools have you used successfully? perf, gdb, and oprofile all seem to look in the 'debug-id' directory, not in 'debug_id'...

...

...
commit 61ed104abf95ac38e7d317c760807f308ea90555 Author: Steven Noonan Date: Wed Feb 12 05:44:16 2014 -0800

makepkg: use dash instead of underscore in /usr/lib/debug/.build-id

Signed-off-by: Steven Noonan

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 027fcc3..7e663af 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1525,7 +1525,7 @@ strip_file() {

# has this file already been stripped if [[ -n "$bid" ]]; then - if [[ -f "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" ]]; then + if [[ -f "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" ]]; then return fi elif [[ -f "$dbgdir/$binary.debug" ]]; then @@ -1546,15 +1546,15 @@ strip_file() {

if [[ -n "$bid" ]]; then local target - mkdir -p "$dbgdir/.build_id/${bid:0:2}" + mkdir -p "$dbgdir/.build-id/${bid:0:2}"

target="../../../../../${binary#./}" target="${target/..\/..\/usr\/lib\/}" target="${target/..\/usr\/}" - ln -s "$target"

"$dbgdir/.build_id/${bid:0:2}/${bid:2}"

...
+ ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}"

target="../../${binary#./}.debug" - ln -s "$target" "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" + ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" fi fi

To justify this change, I can't find any tools that actually look in 'build_id' (with an underscore) when searching for symbols.

For example, perf does this (lines 101, 105):

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/to...

...
GDB also looks in '.build-id' (lines 83, 102):

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/build-...

...
OProfile, same issue (lines 93, 104):

http://sourceforge.net/p/oprofile/oprofile/ci/master/tree/libutil++/bfd_supp...

...
I noticed tool breakage back when I submitted the kernel module split+debug patch, but kept the patch to myself because I figured I must have been missing the rationale for the difference, but I've been so far unable to find any.

- Steven

Dave Reisner

6 p.m.

On Mar 29, 2014 1:52 PM, "Steven Noonan" wrote:

...

On Sat, Mar 29, 2014 at 10:41 AM, Dave Reisner wrote:

...
On Mar 29, 2014 1:36 PM, "Steven Noonan" wrote:

...
Hi folks,

I think the directory Pacman is using for the split-out debug symbols is incorrect. This appears to be needed:

Why do you think this? What are the symptoms you're seeing? I use debug packages all the time and they work as expected.

I've seen tools complain they can't find debug symbols or simply not show

any.

...

What tools have you used successfully? perf, gdb, and oprofile all seem to look in the 'debug-id' directory, not in 'debug_id'...

gdb and valgrind, mostly. I've not seen either complain about missing symbols.

...

...
...
commit 61ed104abf95ac38e7d317c760807f308ea90555 Author: Steven Noonan Date: Wed Feb 12 05:44:16 2014 -0800

makepkg: use dash instead of underscore in /usr/lib/debug/.build-id

Signed-off-by: Steven Noonan

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 027fcc3..7e663af 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1525,7 +1525,7 @@ strip_file() {

# has this file already been stripped if [[ -n "$bid" ]]; then - if [[ -f "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" ]]; then + if [[ -f "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" ]]; then return fi elif [[ -f "$dbgdir/$binary.debug" ]]; then @@ -1546,15 +1546,15 @@ strip_file() {

if [[ -n "$bid" ]]; then local target - mkdir -p "$dbgdir/.build_id/${bid:0:2}" + mkdir -p "$dbgdir/.build-id/${bid:0:2}"

target="../../../../../${binary#./}" target="${target/..\/..\/usr\/lib\/}" target="${target/..\/usr\/}" - ln -s "$target"

"$dbgdir/.build_id/${bid:0:2}/${bid:2}"

...
+ ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}"

target="../../${binary#./}.debug" - ln -s "$target" "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" + ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" fi fi

To justify this change, I can't find any tools that actually look in 'build_id' (with an underscore) when searching for symbols.

For example, perf does this (lines 101, 105):

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/to...

...
...
GDB also looks in '.build-id' (lines 83, 102):

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/build-...

...
...
OProfile, same issue (lines 93, 104):

http://sourceforge.net/p/oprofile/oprofile/ci/master/tree/libutil++/bfd_supp...

...
...
I noticed tool breakage back when I submitted the kernel module split+debug patch, but kept the patch to myself because I figured I must have been missing the rationale for the difference, but I've been so far unable to find any.

- Steven

Steven Noonan

6:04 p.m.

On Sat, Mar 29, 2014 at 11:00 AM, Dave Reisner wrote:

...

On Mar 29, 2014 1:52 PM, "Steven Noonan" wrote:

...
On Sat, Mar 29, 2014 at 10:41 AM, Dave Reisner wrote:

...
On Mar 29, 2014 1:36 PM, "Steven Noonan" wrote:

...
Hi folks,

I think the directory Pacman is using for the split-out debug symbols is incorrect. This appears to be needed:

Why do you think this? What are the symptoms you're seeing? I use debug packages all the time and they work as expected.

I've seen tools complain they can't find debug symbols or simply not show

any.

...
What tools have you used successfully? perf, gdb, and oprofile all seem to look in the 'debug-id' directory, not in 'debug_id'...

gdb and valgrind, mostly. I've not seen either complain about missing symbols.

Hmm. It would be interesting to get an strace of gdb/valgrind on your system and see if it's really opening/reading those files, because based on my inspection of perf/oprofile/gdb sources, they don't know about '.build_id'.

...

...
...
...
commit 61ed104abf95ac38e7d317c760807f308ea90555 Author: Steven Noonan Date: Wed Feb 12 05:44:16 2014 -0800

makepkg: use dash instead of underscore in /usr/lib/debug/.build-id

Signed-off-by: Steven Noonan

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 027fcc3..7e663af 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1525,7 +1525,7 @@ strip_file() {

# has this file already been stripped if [[ -n "$bid" ]]; then - if [[ -f "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" ]]; then + if [[ -f "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" ]]; then return fi elif [[ -f "$dbgdir/$binary.debug" ]]; then @@ -1546,15 +1546,15 @@ strip_file() {

if [[ -n "$bid" ]]; then local target - mkdir -p "$dbgdir/.build_id/${bid:0:2}" + mkdir -p "$dbgdir/.build-id/${bid:0:2}"

target="../../../../../${binary#./}" target="${target/..\/..\/usr\/lib\/}" target="${target/..\/usr\/}" - ln -s "$target"

"$dbgdir/.build_id/${bid:0:2}/${bid:2}"

...
+ ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}"

target="../../${binary#./}.debug" - ln -s "$target" "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" + ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" fi fi

To justify this change, I can't find any tools that actually look in 'build_id' (with an underscore) when searching for symbols.

For example, perf does this (lines 101, 105):

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/to...

...
...
GDB also looks in '.build-id' (lines 83, 102):

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/build-...

...
...
OProfile, same issue (lines 93, 104):

http://sourceforge.net/p/oprofile/oprofile/ci/master/tree/libutil++/bfd_supp...

...
...
I noticed tool breakage back when I submitted the kernel module split+debug patch, but kept the patch to myself because I figured I must have been missing the rationale for the difference, but I've been so far unable to find any.

- Steven

Steven Noonan

6:15 p.m.

On Sat, Mar 29, 2014 at 11:04 AM, Steven Noonan wrote:

...

On Sat, Mar 29, 2014 at 11:00 AM, Dave Reisner wrote:

...
On Mar 29, 2014 1:52 PM, "Steven Noonan" wrote:

...
On Sat, Mar 29, 2014 at 10:41 AM, Dave Reisner wrote:

...
On Mar 29, 2014 1:36 PM, "Steven Noonan" wrote:

...
Hi folks,

I think the directory Pacman is using for the split-out debug symbols is incorrect. This appears to be needed:

Why do you think this? What are the symptoms you're seeing? I use debug packages all the time and they work as expected.

I've seen tools complain they can't find debug symbols or simply not show

any.

...
What tools have you used successfully? perf, gdb, and oprofile all seem to look in the 'debug-id' directory, not in 'debug_id'...

gdb and valgrind, mostly. I've not seen either complain about missing symbols.

Hmm. It would be interesting to get an strace of gdb/valgrind on your system and see if it's really opening/reading those files, because based on my inspection of perf/oprofile/gdb sources, they don't know about '.build_id'.

Looking through the valgrind sources (via svn), they have a find_buildid function which also looks in '.build-id'. They also link to this page in a comment above the function: http://fedoraproject.org/wiki/RolandMcGrath/BuildID This page also references '.build-id' rather than '.build_id'.

...

...
...
...
...
commit 61ed104abf95ac38e7d317c760807f308ea90555 Author: Steven Noonan Date: Wed Feb 12 05:44:16 2014 -0800

makepkg: use dash instead of underscore in /usr/lib/debug/.build-id

Signed-off-by: Steven Noonan

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 027fcc3..7e663af 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1525,7 +1525,7 @@ strip_file() {

# has this file already been stripped if [[ -n "$bid" ]]; then - if [[ -f "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" ]]; then + if [[ -f "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" ]]; then return fi elif [[ -f "$dbgdir/$binary.debug" ]]; then @@ -1546,15 +1546,15 @@ strip_file() {

if [[ -n "$bid" ]]; then local target - mkdir -p "$dbgdir/.build_id/${bid:0:2}" + mkdir -p "$dbgdir/.build-id/${bid:0:2}"

target="../../../../../${binary#./}" target="${target/..\/..\/usr\/lib\/}" target="${target/..\/usr\/}" - ln -s "$target"

"$dbgdir/.build_id/${bid:0:2}/${bid:2}"

...
+ ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}"

target="../../${binary#./}.debug" - ln -s "$target" "$dbgdir/.build_id/${bid:0:2}/${bid:2}.debug" + ln -s "$target" "$dbgdir/.build-id/${bid:0:2}/${bid:2}.debug" fi fi

To justify this change, I can't find any tools that actually look in 'build_id' (with an underscore) when searching for symbols.

For example, perf does this (lines 101, 105):

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/to...

...
...
GDB also looks in '.build-id' (lines 83, 102):

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/build-...

...
...
OProfile, same issue (lines 93, 104):

http://sourceforge.net/p/oprofile/oprofile/ci/master/tree/libutil++/bfd_supp...

...
...
I noticed tool breakage back when I submitted the kernel module split+debug patch, but kept the patch to myself because I figured I must have been missing the rationale for the difference, but I've been so far unable to find any.

- Steven

Allan McRae

11:23 p.m.

On 30/03/14 04:00, Dave Reisner wrote:

...

On Mar 29, 2014 1:52 PM, "Steven Noonan" wrote:

...
On Sat, Mar 29, 2014 at 10:41 AM, Dave Reisner wrote:

...
On Mar 29, 2014 1:36 PM, "Steven Noonan" wrote:

...
Hi folks,

I think the directory Pacman is using for the split-out debug symbols is incorrect. This appears to be needed:

Why do you think this? What are the symptoms you're seeing? I use debug packages all the time and they work as expected.

I've seen tools complain they can't find debug symbols or simply not show

any.

...
What tools have you used successfully? perf, gdb, and oprofile all seem to look in the 'debug-id' directory, not in 'debug_id'...

gdb and valgrind, mostly. I've not seen either complain about missing symbols.

I think this is an actual bug. I bet gdb/valgrind are finding the /usr/lib/debug/path/to/file symlinks and not using the .build-id path.

3700

Age (days ago)

3700

Last active (days ago)

List overview

Download

6 comments

3 participants

participants (3)

Allan McRae
Dave Reisner
Steven Noonan