Signed-off-by: Barbu Paul - Gheorghe --- lib/libalpm/db.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/libalpm/db.c b/lib/libalpm/db.c index bf9c3f0..63d18be 100644 --- a/lib/libalpm/db.c +++ b/lib/libalpm/db.c @@ -136,8 +136,13 @@ alpm_list_t SYMEXPORT *alpm_db_get_servers(const alpm_db_t *db) int SYMEXPORT alpm_db_set_servers(alpm_db_t *db, alpm_list_t *servers) { ASSERT(db != NULL, return -1); - if(db->servers) FREELIST(db->servers); + + if(db->servers){ + FREELIST(db->servers); + } + db->servers = servers; + return 0; } -- Barbu Paul - Gheorghe Common sense is not so common - Voltaire Visit My GitHub profile to see my open-source projects - https://github.com/paullik

Signed-off-by: Barbu Paul - Gheorghe --- HACKING | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/HACKING b/HACKING index 8a59344..e859bd8 100644 --- a/HACKING +++ b/HACKING @@ -101,6 +101,50 @@ alpm_list_t *alpm_list_add(alpm_list_t *list, void *data) NOT for(a=0;a0;a++,n--) {} +9. Declare all variables at the start of the block. +[source,C] +------------------------------------------- +int SYMEXPORT alpm_db_remove_server(alpm_db_t *db, const char *url) +{ + char *newurl, *vdata = NULL; + + newurl = url; + if(!newurl) { + return -1; + } + + ... + + if(vdata) { + ... + } + + return 1; +} +------------------------------------------- + + NOT + +[source,C] +------------------------------------------- +int SYMEXPORT alpm_db_remove_server(alpm_db_t *db, const char *url) +{ + char *newurl = url; + + if(!newurl) { + return -1; + } + + char *vdata = NULL; + + if(vdata) { + ... + } + + return 1; +} +------------------------------------------- + Other Concerns -------------- -- Barbu Paul - Gheorghe Common sense is not so common - Voltaire Visit My GitHub profile to see my open-source projects - https://github.com/paullik

Signed-off-by: Barbu Paul - Gheorghe --- lib/libalpm/db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libalpm/db.c b/lib/libalpm/db.c index bf9c3f0..4520fe1 100644 --- a/lib/libalpm/db.c +++ b/lib/libalpm/db.c @@ -136,7 +136,7 @@ alpm_list_t SYMEXPORT *alpm_db_get_servers(const alpm_db_t *db) int SYMEXPORT alpm_db_set_servers(alpm_db_t *db, alpm_list_t *servers) { ASSERT(db != NULL, return -1); - if(db->servers) FREELIST(db->servers); + FREELIST(db->servers); db->servers = servers; return 0; } -- Barbu Paul - Gheorghe Common sense is not so common - Voltaire Visit My GitHub profile to see my open-source projects - https://github.com/paullik