Allan McRae pushed to branch master at Pacman / Pacman

Commits: 0e938f18 by Allan McRae at 2022-12-12T18:37:59+10:00 libmakepkg: fix compatibility with bash-5.2 patsub_replacement

Bash-5.2 introduced the patsub_replacement shell option, which is enabled by default. Apparently is it supposed to handle a sed-like idiom, but what it does achieve is making any substitution involving a "&" requiring special care.

For makepkg's DLAGENTS, we replace "%o" and "%u" if present. Any "&" in the replacement fields triggers patsub_replacement unless quoted. This is particularly important for the URL field.

Add relevant quotes to avoid issues.

Signed-off-by: Allan McRae <allan@archlinux.org>

- - - - - 3436bc6c by Allan McRae at 2022-12-13T10:00:13+10:00 Finish comparing all pairs of filenames for duplicates before erroring

This also prevents a use-after-free issue where we free the list we are interating over and the do i->next.

Signed-off-by: Allan McRae <allan@archlinux.org>

- - - - - 0fe764a2 by Allan McRae at 2022-12-13T10:00:13+10:00 Fix memory leak when setting up download bars

Signed-off-by: Allan McRae <allan@archlinux.org>

- - - - - ea83fd39 by Allan McRae at 2022-12-13T10:00:13+10:00 Catch possible error in archive_entry_pathname when extracting files

Prevents a null deference on error.

Signed-off-by: Allan McRae <allan@archlinux.org>

- - - - - 19a85874 by Allan McRae at 2022-12-13T10:00:13+10:00 _alpm_pkg_load_internal: prevent double closing file descriptor

Move closing of the file descriptor until the end of the function, as any following error will lead to a "goto error" that attempts to close it again.

Signed-off-by: Allan McRae <allan@archlinux.org>

- - - - - 775d511f by Allan McRae at 2022-12-13T10:00:13+10:00 load_packages: fix memory leak on error

The memory assigned in _alpm_pkg_load_internal was not freed on error.

Signed-off-by: Allan McRae <allan@archlinux.org>

- - - - - 471a0304 by Allan McRae at 2022-12-13T10:00:13+10:00 Avoid NULL deference in curl_check_finished_download

We have not set handle in the function at this stage, so we can not assign an error to it. Pass the handle to the function to avoid waiting until the payload is retrieved.

Signed-off-by: Allan McRae <allan@archlinux.org>

- - - - - fcb1d4f8 by Allan McRae at 2022-12-13T10:00:13+10:00 makepkg: package debug source files with options 'debug' and '!strip'

When package software with debug symbols without stripping, we should still process the files with debugedit and include the needed source files in the package.

Signed-off-by: Allan McRae <allan@archlinux.org>

- - - - - bb035eba by Allan McRae at 2022-12-13T10:00:13+10:00 gitlab CI: use "meson setup" everywhere

Avoids a warning from meson.

Signed-off-by: Allan McRae <allan@archlinux.org>

- - - - -

8 changed files:

- .gitlab-ci.yml - lib/libalpm/be_package.c - lib/libalpm/dload.c - lib/libalpm/sync.c - lib/libalpm/util.c - scripts/libmakepkg/source/file.sh.in - scripts/libmakepkg/tidy/strip.sh.in - src/pacman/callback.c

View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/1327ce7bd840686847b0193...