[pacman-dev] [PATCH] makepkg: deprecate PKGBUILDs without a package() function
The package() function has been around since pacman-3.3 and has significant advantages including limited fakeroot usage and correct repackaging. The ability to use PKGBUILDs without a package function will be removed in a future release. Signed-off-by: Allan McRae <allan@archlinux.org> --- scripts/makepkg.sh.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 8a300cb..337ada9 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -2785,6 +2785,10 @@ fi fullver=$(get_full_version) msg "$(gettext "Making package: %s")" "$pkgbase $fullver ($(date))" +if (( !PKGFUNC && !SPLITPKG )); then + warning "$(gettext "Using a %s without a %s function is deprecated.")" "$BUILDSCRIPT" "package()" +fi + # if we are creating a source-only package, go no further if (( SOURCEONLY )); then if [[ -f $SRCPKGDEST/${pkgbase}-${fullver}${SRCEXT} ]] \ -- 1.7.12.1
On 24/09/12 14:36, Allan McRae wrote:
The package() function has been around since pacman-3.3 and has significant advantages including limited fakeroot usage and correct repackaging. The ability to use PKGBUILDs without a package function will be removed in a future release.
I though it better to deprecate this for at least one release. We have been warning about using "makepkg -R" without a package function for some time. I am quite happy to kill this now if people think that would be OK. Allan
participants (1)
-
Allan McRae