[pacman-dev] [PATCH] pacman-key: ignores keys already lsigned during populate
WORK IN PROGRESS. I'm only emailing this patch to get some
feedback. I added a function that checks whether a key
being imported has already been signed, and if it has been,
skip lsigning it.
I'm not 100% sure this line is entirely necessary:
if (( LSIGNKEY || POPULATE )); then
I wanted to ensure that there -was- a signing key to check
against. It might be a superfluous check, but I couldn't
find where --populate implies having run --init. I may've
missed it.
Otherwise, just looking for feedback before I move on to
step 2 which is not disabling already disabled keys. Let
me know if there are any glaring errors you see, or if
there is a more elegant way of doing what I did.
Signed-off-by: Matthew Sexton
+lsigned_already() { + # Determines whether a key has already been signed locally by getting
On Monday, November 4, 2019 12:08:15 PM EST you wrote: the
+ # local pacman secret key and comparing it against signatures on the key + # returns 1 if key is not signed, 0 if signed
I edited this, but forgot to save it before making the patch. This function returns nothing. It changes a variable NEEDS_SIGNED.
participants (1)
-
Matthew Sexton