[pacman-dev] [PATCH] makepkg: warn about repackaging without a package function
File permissions are not guaranteed to stay the same on exit from fakeroot,
so repackaging may result in files with different permissions. This is
avioded when using a package() function (or split packages) as the
packaging step is rerun.
Signed-off-by: Allan McRae
On Wed, Apr 14, 2010 at 8:29 AM, Allan McRae
File permissions are not guaranteed to stay the same on exit from fakeroot, so repackaging may result in files with different permissions. This is avioded when using a package() function (or split packages) as the packaging step is rerun.
Signed-off-by: Allan McRae
--- Two areas to comment on:
1) "makepkg -R --asroot" does not give this warning. This is because it is assumed that the initial packaging stage was also done as root and so file permissions will be correct. Is that a fair assumption?
2) Should we depricate repackaging without a package function in pacman-3.5? Using a package function was supported in 3.3 and using only a package function (no build function) will be supported in 3.4. If that is reasonable, I will alter the warning and add it to the --asroot case too.
I would deprecate all pkgbuilds that do not have a package() function. But I find it especially nicer when using -R, so I am totally for that warning in that case.
participants (2)
-
Allan McRae
-
Xavier Chantry