Re: [pacman-dev] pacman-contrib package
On Sun, Mar 02, 2008 at 09:27:59PM +1000, Allan McRae wrote:
Xavier wrote:
Arf, I was trying to make some change to that syntax file this morning. My changes didn't seem to have any effect, it was driving me mad. After a while, I figured out I had both pkgbuild.vim and PKGBUILD.vim files in ftdetect and syntax :P That's because pacman-contrib installs PKGBUILD.vim, but Nathan's instructions which I followed previously used pkgbuild.vim : http://www.archlinux.org/pipermail/pacman-dev/2008-January/010782.html
Anyway, both license=('foo') and license=foo work fine now.
Great. I tried but seemed to make things worse!
Hmm, I just realized what I said wasn't clear. The consequence of what I said above is that I had both PKGBUILD.vim and pkgbuild.vim. I was editing the PKGBUILD.vim one, but it was actually pkgbuild.vim which was used. So my changes were ignored.
But I think only the first should be supported (the man page says that license is an array), so I updated PKGBUILD.vim accordingly I agree. license=foo is technically wrong so we should not support it. I think of it as as subtle way to improve PKGBUILD quality.
Ok good.
Xavier wrote:
Hmm, I just realized what I said wasn't clear. The consequence of what I said above is that I had both PKGBUILD.vim and pkgbuild.vim. I was editing the PKGBUILD.vim one, but it was actually pkgbuild.vim which was used. So my changes were ignored.
I stuck with the case used for the file in the contrib directory. I don't know a workaround for that. I can add a post install message indicating people should remove the lowercase one for the next version. My guess is that most people with the lowercase version are on this list anyway, so hopefully they have seen this! Allan
participants (2)
-
Allan McRae
-
Xavier