[pacman-dev] [PATCH] Remove dead stores reported by clang-analyzer
Signed-off-by: Sebastian Nowicki <sebnow@gmail.com> --- lib/libalpm/be_local.c | 2 +- lib/libalpm/pkghash.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c index 82c1d59..788b3c6 100644 --- a/lib/libalpm/be_local.c +++ b/lib/libalpm/be_local.c @@ -405,7 +405,7 @@ static int local_db_populate(pmdb_t *db) * http://kerneltrap.org/mailarchive/linux-btrfs/2010/1/23/6723483/thread */ est_count = 0; - while((ent = readdir(dbdir)) != NULL) { + while(readdir(dbdir) != NULL) { est_count++; } rewinddir(dbdir); diff --git a/lib/libalpm/pkghash.c b/lib/libalpm/pkghash.c index 761ca72..b4dfcb6 100644 --- a/lib/libalpm/pkghash.c +++ b/lib/libalpm/pkghash.c @@ -84,12 +84,11 @@ pmpkghash_t *_alpm_pkghash_create(size_t size) static size_t get_hash_position(unsigned long name_hash, pmpkghash_t *hash) { size_t position; - alpm_list_t *ptr; position = name_hash % hash->buckets; /* collision resolution using open addressing with linear probing */ - while((ptr = hash->hash_table[position]) != NULL) { + while(hash->hash_table[position] != NULL) { position = (position + 1) % hash->buckets; } -- 1.7.4.2
On Sun, Apr 3, 2011 at 8:14 AM, Sebastian Nowicki <sebnow@gmail.com> wrote:
Signed-off-by: Sebastian Nowicki <sebnow@gmail.com> --- lib/libalpm/be_local.c | 2 +- lib/libalpm/pkghash.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
I didn't send these yesterday to the ML as they looked trivial enough, but maybe I should have. http://code.toofishes.net/cgit/xavier/pacman.git/log/?h=working
On Sun, Apr 3, 2011 at 3:35 PM, Xavier Chantry <chantry.xavier@gmail.com>wrote:
On Sun, Apr 3, 2011 at 8:14 AM, Sebastian Nowicki <sebnow@gmail.com> wrote:
Signed-off-by: Sebastian Nowicki <sebnow@gmail.com> --- lib/libalpm/be_local.c | 2 +- lib/libalpm/pkghash.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
I didn't send these yesterday to the ML as they looked trivial enough, but maybe I should have. http://code.toofishes.net/cgit/xavier/pacman.git/log/?h=working
I thought you might have already done this when you found the open_mode bug from clang-analyzer :).
On 03/04/11 17:35, Xavier Chantry wrote:
On Sun, Apr 3, 2011 at 8:14 AM, Sebastian Nowicki<sebnow@gmail.com> wrote:
Signed-off-by: Sebastian Nowicki<sebnow@gmail.com> --- lib/libalpm/be_local.c | 2 +- lib/libalpm/pkghash.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
I didn't send these yesterday to the ML as they looked trivial enough, but maybe I should have. http://code.toofishes.net/cgit/xavier/pacman.git/log/?h=working
Please send patches to the list so that we can complain about issues like: aba191d5 (Xavier Chantry 2011-04-03 10:28:09 +0200 276) printf("%lc", *p); util.c: In function ‘indentprint’: util.c:276:3: error: format ‘%lc’ expects argument of type ‘wint_t’, but argument 2 has type ‘wchar_t’ [-Werror=format] cc1: all warnings being treated as errors Allan
Allan McRae wrote:
Please send patches to the list so that we can complain about issues like:
aba191d5 (Xavier Chantry 2011-04-03 10:28:09 +0200 276) printf("%lc", *p);
util.c: In function ‘indentprint’: util.c:276:3: error: format ‘%lc’ expects argument of type ‘wint_t’, but argument 2 has type ‘wchar_t’ [-Werror=format] cc1: all warnings being treated as errors
This one was not supposed to be committed, I know Dan would have rejected it anyway. I was just pissed off by this dumb issue, and I did not manage to make gcc break. Is that with gcc 4.6 (I was on 4.5) ?
On 04/04/11 18:58, Xavier wrote:
Allan McRae wrote:
Please send patches to the list so that we can complain about issues like:
aba191d5 (Xavier Chantry 2011-04-03 10:28:09 +0200 276) printf("%lc", *p);
util.c: In function ‘indentprint’: util.c:276:3: error: format ‘%lc’ expects argument of type ‘wint_t’, but argument 2 has type ‘wchar_t’ [-Werror=format] cc1: all warnings being treated as errors
This one was not supposed to be committed, I know Dan would have rejected it anyway. I was just pissed off by this dumb issue, and I did not manage to make gcc break. Is that with gcc 4.6 (I was on 4.5) ?
OK. That was with a gcc-4.7 snapshot (which is still quite close to what gcc-4.6 is). Allan
participants (4)
-
Allan McRae
-
Sebastian Nowicki
-
Xavier
-
Xavier Chantry