Allan McRae wrote:

Well, Xavier beat me to it.... so ignore this thread!

Waoh, two different versions of the same patch in 4 min interval, that was pretty amazing :) Actually, if we combine our two patches, by not editing the big string with the Y/n part like you did, and by reusing the already translated YES and Y strings like I did, maybe we can avoid changing the .po files. But then, we need to check that everyone did translate the [Y/n] part if that string, so exactly the opposite of what I was doing until now : making sure everyone kept it intact. So in any cases, it looks like we will need to do some manual checking and fixing of the translations. So what could be done is once every translation has been updated, my patch is merged, the .po file are regenerated and each one fixed manually. This should be easy to do.

Aaron Griffin wrote:

On Fri, Jul 18, 2008 at 1:41 AM, Allan McRae wrote:

...

answer=$(echo $answer | tr '[:upper:]' '[:lower:]')

Random unrelated point - can this line possibly cause issues similar to the Turkish I/i thing?

Maybe, what is the Turkish I/i thing? (Maybe its another language because I think Y=E, n=h in turkish).

On Fri, Jul 18, 2008 at 5:27 PM, Aaron Griffin wrote:

On Fri, Jul 18, 2008 at 1:41 AM, Allan McRae wrote:

...

answer=$(echo $answer | tr '[:upper:]' '[:lower:]')

Random unrelated point - can this line possibly cause issues similar to the Turkish I/i thing?

This is a very good point that I never thought about. And since we already have the equivalent code in pacman, pacman is potentially affected too. Since I only heard about problem in Turkish locale, we can just look at the translation of yes/no in turkish : msgid "Y" msgstr "E" msgid "YES" msgstr "EVET" msgid "N" msgstr "H" msgid "NO" msgstr "HAYIR" But now that I think about it, it should not be a problem. Turkish users should be able to write HAYIR in lower case, something like hayir, but without the dot on the i. It is not like the keywords like RootDir which were already written like that in pacman.conf, then converted to upper case and compared to ROOTDIR. So in short, it looks like there is no problem here, after thinking about it.