[pacman-dev] [PATCH] Stop reinstalling message when using print-uris
The stops the "pkg is up to date -- reinstalling" message when only asking for uris to be printed. Signed-off-by: Allan McRae <mcrae_allan@hotmail.com> --- lib/libalpm/sync.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 0d6a6ee..02d64ea 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -339,7 +339,7 @@ int _alpm_sync_addtarget(pmtrans_t *trans, pmdb_t *db_local, alpm_list_t *dbs_sy alpm_pkg_get_name(local), alpm_pkg_get_version(local)); return(0); } else { - if(!(trans->flags & PM_TRANS_FLAG_DOWNLOADONLY)) { + if(!(trans->flags & (PM_TRANS_FLAG_DOWNLOADONLY | PM_TRANS_FLAG_PRINTURIS))) { _alpm_log(PM_LOG_WARNING, _("%s-%s is up to date -- reinstalling\n"), alpm_pkg_get_name(local), alpm_pkg_get_version(local)); } -- 1.5.5.1
On Mon, May 26, 2008 at 8:26 AM, Allan McRae <mcrae_allan@hotmail.com> wrote:
The stops the "pkg is up to date -- reinstalling" message when only asking for uris to be printed.
Slightly offtopic, but this patch reminded me of a problem with these reinstalling message. I just looked into it and the messages are just wrong. The comment is correct though : /* spkg is NOT an upgrade */ but saying that local pkg is up to date is misleading, the two situations should be considered : 1) local pkg is in sync with spkg, ie same version In this cases, the two messages make sense : local pkg is uptodate, then either skipping or reinstalling 2) local pkg is newer than sync one in this case, the two messages are misleading Well, I don't have time right now to think about how to solve this, but I am sending it on the ML anyway in case someone can help, or otherwise just as a reminder for me :)
participants (2)
-
Allan McRae
-
Xavier