[pacman-dev] [PATCH] makepkg: Add DEBUGDEST for a pkgtype of debug
Fixes FS#48902.
This patch piggybacks on makepkg's internal knowledge of the package
name to move packages of type "debug" (more on this later) to a user
defined directory.
The goal is to make moving only debug packages to a debug repo in a
reliable manner without using globbing to try and guess if a package is
a debug package or not.
This concept patch adds a new global variable called "pkgtype" which
defines the kind of package it is, currently the only pkgtype is "debug".
I've left non-debug pkgtypes to indicate a normal package but it may be
potentially expanded with different types of package in future.
Currently pkg_file is updated based on the variable and prefers
DEBUGDEST if it is defined otherwise falling back on PKGDEST which
essentially treats debug packages as normal packages if DEBUGDEST is not
configured.
Signed-off-by: Earnestly
On 14/04/16 00:36, Earnestly via pacman-dev wrote:
Fixes FS#48902.
This patch piggybacks on makepkg's internal knowledge of the package name to move packages of type "debug" (more on this later) to a user defined directory.
The goal is to make moving only debug packages to a debug repo in a reliable manner without using globbing to try and guess if a package is a debug package or not.
This concept patch adds a new global variable called "pkgtype" which defines the kind of package it is, currently the only pkgtype is "debug".
I've left non-debug pkgtypes to indicate a normal package but it may be potentially expanded with different types of package in future.
Currently pkg_file is updated based on the variable and prefers DEBUGDEST if it is defined otherwise falling back on PKGDEST which essentially treats debug packages as normal packages if DEBUGDEST is not configured.
My initial feeling is there is no need for this. There are 0 packages with names ending in "-debug" in Arch Linux and maybe 5 in the AUR. It is also quite quick to extract the list of package file names and match them to debugs variants. This leads me to question what problem this is solving. Unless a strong case can be made for its inclusion, I am inclined to not make this change. Allan
On Mon, Apr 18, 2016 at 02:50:06PM +1000, Allan McRae wrote:
My initial feeling is there is no need for this. There are 0 packages with names ending in "-debug" in Arch Linux and maybe 5 in the AUR. It is also quite quick to extract the list of package file names and match them to debugs variants.
Indeed, as we discussed on IRC there are infact not only no packages ending with -debug, but that the pattern *-debug-* doesn't appear anywhere. It is still not guaranteed to match -debug- packages but it's pretty damn likely.
This leads me to question what problem this is solving. Unless a strong case can be made for its inclusion, I am inclined to not make this change.
Based on the above it might be better to not include this patch. I do still think there is perhaps some merit in using the pkgtype concept, I'm not exactly sure what that merit is yet... YAGNI
participants (2)
-
Allan McRae
-
Earnestly