November 2008 - Aur-dev - lists.archlinux.org

[aur-dev] [PATCH] Turn on package notification by default for new packages
by Callan Barrett 18 Jun '09

18 Jun '09

Version using package functions Signed-off-by: Callan Barrett <wizzomafizzo(a)gmail.com> --- web/html/pkgsubmit.php | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 78d6e50..450e9b6 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -328,6 +328,7 @@ if ($_COOKIE["AURSID"]): header('Location: packages.php?ID=' . $pdata['ID']); } else { + $uid = uid_from_sid($_COOKIE["AURSID"]); # This is a brand new package $q = sprintf("INSERT INTO Packages (Name, License, Version, CategoryID, Description, URL, LocationID, SubmittedTS, SubmitterUID, MaintainerUID, FSPath, URLPath) VALUES ('%s', '%s', '%s-%s', %d, '%s', '%s', 2, UNIX_TIMESTAMP(), %d, %d, '%s', '%s')", @@ -338,8 +339,8 @@ if ($_COOKIE["AURSID"]): mysql_real_escape_string($_REQUEST['category']), mysql_real_escape_string($new_pkgbuild['pkgdesc']), mysql_real_escape_string($new_pkgbuild['url']), - uid_from_sid($_COOKIE["AURSID"]), - uid_from_sid($_COOKIE["AURSID"]), + $uid, + $uid, mysql_real_escape_string(INCOMING_DIR . $pkg_name . "/" . $pkg_name . ".tar.gz"), mysql_real_escape_string(URL_DIR . $pkg_name . "/" . $pkg_name . ".tar.gz")); @@ -370,6 +371,8 @@ if ($_COOKIE["AURSID"]): $q .= $packageID . ", '" . mysql_real_escape_string($src) . "')"; db_query($q, $dbh); } + + pkg_notify(account_from_sid($_COOKIE["AURSID"]), array($packageID)); header('Location: packages.php?ID=' . $packageID); -- 1.6.0.2

2 1

[aur-dev] Turkish translation fix
by Samed Beyribey 27 Nov '08

27 Nov '08

Hello, There were some typos and non translated strings in tr (turkish) lang files, so i've fixed them. I've attached the patch. Regards, Samed.

2 1

[aur-dev] Series of tupkg improvements.
by Loui Chang 27 Nov '08

27 Nov '08

Here comes a series of patches for tupkg, particularly tupkgupdate. One of the most recent patches actually broke tupkgupdate. I've tested these on my own mini community repo. Hah it's pretty exciting to begin to understand its quirky workings.

3 8

[aur-dev] Git patch for AUR navigation links
by Thayer Williams 25 Nov '08

25 Nov '08

I'm not sure who the rightful recipient for this patch is, but could someone with commit priveledges apply this patch to the AUR git project? It replaces the top navigation "Get Arch" link with "Download". Thanks! Thayer

2 2

[aur-dev] [patch] ru translation mistypes
by Sergej Pupykin 24 Nov '08

24 Nov '08

Hi, 3 mistypes fixed by this patch.

1 0

[aur-dev] [PATCH] Remove redundant tupkgs.conf.
by Loui Chang 24 Nov '08

24 Nov '08

I've pushed this. Signed-off-by: Loui Chang <louipc.ist(a)gmail.com> --- support/scripts/tupkgs.conf | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) delete mode 100644 support/scripts/tupkgs.conf diff --git a/support/scripts/tupkgs.conf b/support/scripts/tupkgs.conf deleted file mode 100644 index ab10866..0000000 --- a/support/scripts/tupkgs.conf +++ /dev/null @@ -1,10 +0,0 @@ -[tupkgs] -port = 1034 -cachedir = /home/aur/packages/full -incomingdir = /home/aur/packages/partial - -[mysql] -username = aur -password = PbLus6wH -host = localhost -db = aur -- 1.6.0.4

1 0

[aur-dev] [PATCH] Clean up packages.php and document new package functions
by Callan Barrett 23 Nov '08

23 Nov '08

Signed-off-by: Callan Barrett <wizzomafizzo(a)gmail.com> --- web/html/packages.php | 65 +++++++++++++++++++------------------------------ web/lib/pkgfuncs.inc | 48 ++++++++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+), 40 deletions(-) diff --git a/web/html/packages.php b/web/html/packages.php index f06aaa1..9c611d8 100644 --- a/web/html/packages.php +++ b/web/html/packages.php @@ -8,38 +8,31 @@ include("search_po.inc"); # use some form of this for i18n support set_lang(); # this sets up the visitor's language check_sid(); # see if they're still logged in -# set the title to something useful depending on -# what "page" we're on -# +# Set the title to the current query if required if (isset($_GET['ID'])) { - $id = pkgname_from_id($_GET['ID']); - if (!empty($id)) { - $title = $id; - } -} else if (!empty($_GET['K'])) { - $title = "Search: " . $_GET['K']; + if (pkgname_from_id($_GET['ID'])) { $title = $id; } +} else if (!empty($_GET['K'])) { + $title = __("Search Criteria") . ": " . $_GET['K']; } else { $title = __("Packages"); } -html_header($title); - -# get login privileges -# +# Retrieve account type if (isset($_COOKIE["AURSID"])) { - # Only logged in users can do stuff - # $atype = account_from_sid($_COOKIE["AURSID"]); } else { $atype = ""; } -# grab the list of Package IDs to be operated on +# Grab the list of Package IDs to be operated on # +# TODO: Convert this to a normal array of IDs to operate on and convert the +# functions to use this format isset($_POST["IDs"]) ? $ids = $_POST["IDs"] : $ids = array(); -# determine what button the visitor clicked -# +html_header($title); + +# Determine what action to do if ($_POST['action'] == "do_Flag" || isset($_POST['do_Flag'])) { print ""; print pkg_flag($atype, $ids, True); @@ -48,18 +41,14 @@ if ($_POST['action'] == "do_Flag" || isset($_POST['do_Flag'])) { print ""; print pkg_flag($atype, $ids, False); print ""; -} elseif ($_POST['action'] == "do_Disown" || isset($_POST['do_Disown'])) { - print ""; - print pkg_adopt($atype, $ids, False); - print ""; -} elseif ($_POST['action'] == "do_Delete" || isset($_POST['do_Delete'])) { - print ""; - print pkg_delete($atype, $ids, False); - print ""; } elseif ($_POST['action'] == "do_Adopt" || isset($_POST['do_Adopt'])) { print ""; print pkg_adopt($atype, $ids, True); print ""; +} elseif ($_POST['action'] == "do_Disown" || isset($_POST['do_Disown'])) { + print ""; + print pkg_adopt($atype, $ids, False); + print ""; } elseif ($_POST['action'] == "do_Vote" || isset($_POST['do_Vote'])) { print ""; print pkg_vote($atype, $ids, True); @@ -68,26 +57,22 @@ if ($_POST['action'] == "do_Flag" || isset($_POST['do_Flag'])) { print ""; print pkg_vote($atype, $ids, False); print ""; -} elseif (isset($_GET["ID"])) { - - if (!intval($_GET["ID"])) { - print __("Error trying to retrieve package details.")." \n"; - - } else { - package_details($_GET["ID"], $_COOKIE["AURSID"]); - } - +} elseif ($_POST['action'] == "do_Delete" || isset($_POST['do_Delete'])) { + print ""; + print pkg_delete($atype, $ids); + print ""; } elseif ($_POST['action'] == "do_Notify" || isset($_POST['do_Notify'])) { print ""; print pkg_notify($atype, $ids); print ""; +} elseif (isset($_GET["ID"])) { + if (!is_numeric($_GET["ID"])) { + print __("Error trying to retrieve package details.") . " "; + } else { + package_details($_GET["ID"], $_COOKIE["AURSID"]); + } } else { - # just do a search - # pkg_search_page($_COOKIE["AURSID"]); - } html_footer(AUR_VERSION); - -?> diff --git a/web/lib/pkgfuncs.inc b/web/lib/pkgfuncs.inc index 5c179fa..9941103 100644 --- a/web/lib/pkgfuncs.inc +++ b/web/lib/pkgfuncs.inc @@ -985,6 +985,17 @@ function pkg_search_page($SID="") { return; } +/** + * Flag and un-flag packages out-of-date + * + * @param string $atype Account type, output of account_from_sid + * @param array $ids Array of package IDs to flag/unflag, formatted as + * $package_id => $useless_crap + * @param boolean $action True flags out-of-date, false un-flags. Flags by + * default + * + * @return string Translated success or error messages + */ function pkg_flag ($atype, $ids, $action = True) { if (!$atype) { if ($action) { @@ -1059,6 +1070,15 @@ function pkg_flag ($atype, $ids, $action = True) { } } +/** + * Delete packages + * + * @param string $atype Account type, output of account_from_sid + * @param array $ids Array of package IDs to delete, formatted as + * $package_id => $useless_crap + * + * @return string Translated error or success message + */ function pkg_delete ($atype, $ids) { if (!$atype) { return __("You must be logged in before you can disown packages."); @@ -1132,6 +1152,16 @@ function pkg_delete ($atype, $ids) { return __("The selected packages have been deleted."); } +/** + * Adopt or disown packages + * + * @param string $atype Account type, output of account_from_sid + * @param array $ids Array of package IDs to adopt/disown, formatted as + * $package_id => $whatever + * @param boolean $action Adopts if true, disowns if false. Adopts by default + * + * @return string Translated error or success message + */ function pkg_adopt ($atype, $ids, $action = True) { if (!$atype) { if ($action) { @@ -1190,6 +1220,16 @@ function pkg_adopt ($atype, $ids, $action = True) { } } +/** + * Vote and un-vote for packages + * + * @param string $atype Account type, output of account_from_sid + * @param array $ids Array of package IDs to vote/un-vote, formatted as + * $package_id => $useless + * @param boolean $action Votes if true, un-votes if false. Votes by default + * + * @return string Translated error or success message + */ function pkg_vote ($atype, $ids, $action = True) { if (!$atype) { if ($action) { @@ -1267,6 +1307,14 @@ function pkg_vote ($atype, $ids, $action = True) { } } +/** + * Toggle notification of packages + * + * @param string $atype Account type, output of account_from_sid + * @param array $ids Array of package IDs to toggle, formatted as $package_id => $crap + * + * @return string Translated error or success message + */ function pkg_notify ($atype, $ids) { if (!$atype) { return __("You must be logged in before you can get notifications on comments."); -- 1.6.0.2

2 1

[aur-dev] [patch] russian translation update
by Sergej Pupykin 19 Nov '08

19 Nov '08

Hi, this is russian translation update.

2 1

[aur-dev] [PATCH] Make remembered sessions actually save themselves.
by Loui Chang 14 Nov '08

14 Nov '08

1 0

[aur-dev] [PATCH] Move package notification into a function.
by Loui Chang 13 Nov '08

13 Nov '08

Here's a new patch for new notification behaviour. Giv'er a spin!

1 1