November 2007 - Pacman-dev - lists.archlinux.org

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.0.0-511-g381690f
by Dan McGee 04 Nov '07

04 Nov '07

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 381690f9b3c38f51835bf4d48835d9fc830d66b1 (commit) via ab91cef65503e3162d33146414cb901c6cb60597 (commit) via dea9b3bc0f6ba49aec8452958f5373fbb20e7df2 (commit) via 4a5e7b6bd1a887f67b9b9ec8115250fc92c741ca (commit) via 0ea43089e1b95bd7b4e25ca170e155295f2b2b2d (commit) via bcb5465b21f6cafbd044d9aa3b6418dbac909638 (commit) from ccdf29ffa8436d3cd5409b0d02287207716cf397 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 381690f9b3c38f51835bf4d48835d9fc830d66b1 Author: Dan McGee <dan(a)archlinux.org> Date: Tue Oct 30 20:21:55 2007 -0500 Update my TODO commit ab91cef65503e3162d33146414cb901c6cb60597 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Oct 31 11:37:49 2007 -0500 Add a little const correctness fix to alpm_list Signed-off-by: Dan McGee <dan(a)archlinux.org> commit dea9b3bc0f6ba49aec8452958f5373fbb20e7df2 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Oct 31 11:43:04 2007 -0500 Fix basename usage in pacman and utilities basename() is a rather untrusty function call on a lot of platforms as it does some weird and different things. To solve this, I added a mbasename fuction to pacman to take its place, and simply removed its usage in the utilities (it isn't worth dealing with there). Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 4a5e7b6bd1a887f67b9b9ec8115250fc92c741ca Author: Roman Kyrylych <roman(a)archlinux.org> Date: Wed Oct 31 18:41:17 2007 +0200 Add support for arch='any' Signed-off-by: Roman Kyrylych <roman(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 0ea43089e1b95bd7b4e25ca170e155295f2b2b2d Author: Dan McGee <dan(a)archlinux.org> Date: Wed Oct 31 15:12:33 2007 -0500 Remove final use of the math library from pacman To round a value, we don't need floorf- we can just cast to an int. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit bcb5465b21f6cafbd044d9aa3b6418dbac909638 Author: Jeff Mickey <jeff(a)archlinux.org> Date: Fri Nov 2 18:26:31 2007 -0400 Added optdepends support to pactest Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: TODO.dan | 32 ++++---------------------------- configure.ac | 3 --- lib/libalpm/alpm_list.c | 7 ++++--- pactest/pmdb.py | 4 ++++ pactest/pmpkg.py | 3 +++ pactest/pmrule.py | 3 +++ pactest/util.py | 2 ++ scripts/gensync.sh.in | 3 +++ scripts/makepkg.sh.in | 4 ++++ scripts/updatesync.sh.in | 3 +++ src/pacman/callback.c | 3 +-- src/pacman/pacman.c | 36 +++++++++++++++++++++++++++++------- src/util/testdb.c | 4 +++- src/util/testpkg.c | 4 +++- 14 files changed, 66 insertions(+), 45 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] Added optdepends support to pactest
by Jeff Mickey 03 Nov '07

03 Nov '07

diff --git a/pactest/pmdb.py b/pactest/pmdb.py index 5d5104f..ebde324 100755 --- a/pactest/pmdb.py +++ b/pactest/pmdb.py @@ -187,6 +187,8 @@ class pmdb: line = line.strip("\n") if line == "%DEPENDS%": pkg.depends = _getsection(fd) + elif line == "%OPTDEPENDS%": + pkg.optdepends = _getsection(fd) elif line == "%REQUIREDBY%": pkg.requiredby = _getsection(fd) elif line == "%CONFLICTS%": @@ -291,6 +293,8 @@ class pmdb: data = [] if pkg.depends: data.append(_mksection("DEPENDS", pkg.depends)) + if pkg.optdepends: + data.append(_mksection("OPTDEPENDS", pkg.optdepends)) if self.treename == "local": if pkg.requiredby: data.append(_mksection("REQUIREDBY", pkg.requiredby)) diff --git a/pactest/pmpkg.py b/pactest/pmpkg.py index c6859e8..410423d 100755 --- a/pactest/pmpkg.py +++ b/pactest/pmpkg.py @@ -53,6 +53,7 @@ class pmpkg: self.force = 0 # sync only (will be moved to depends) # depends self.depends = [] + self.optdepends = [] self.requiredby = [] # local only self.conflicts = [] self.provides = [] @@ -146,6 +147,8 @@ class pmpkg: data.append("group = %s" % i) for i in self.depends: data.append("depend = %s" % i) + for i in self.optdepends: + data.append("optdepend = %s" % i) for i in self.conflicts: data.append("conflict = %s" % i) for i in self.provides: diff --git a/pactest/pmrule.py b/pactest/pmrule.py index d5d0f56..c5682dc 100755 --- a/pactest/pmrule.py +++ b/pactest/pmrule.py @@ -83,6 +83,9 @@ class pmrule: elif case == "DEPENDS": if not value in newpkg.depends: success = 0 + elif case == "OPTDEPENDS": + if not value in newpkg.optdepends: + success = 0 elif case == "REQUIREDBY": if not value in newpkg.requiredby: success = 0 diff --git a/pactest/util.py b/pactest/util.py index d320342..ae20374 100755 --- a/pactest/util.py +++ b/pactest/util.py @@ -149,6 +149,8 @@ def mkdescfile(filename, pkg): data.append("replaces = %s" % i) for i in pkg.depends: data.append("depend = %s" % i) + for i in pkg.optdepends: + data.append("optdepend = %s" % i) for i in pkg.conflicts: data.append("conflict = %s" % i) for i in pkg.provides: -- 1.5.2.4

2 1

Re: [pacman-dev] [arch-dev-public] Fwd: [arch] circular dependence in core
by Xavier 01 Nov '07

01 Nov '07

On Thu, Nov 01, 2007 at 06:17:31PM +0200, Roman Kyrylych wrote: > 2007/11/1, Roman Kyrylych <roman.kyrylych(a)gmail.com>: > > 2007/11/1, Aaron Griffin <aaronmgriffin(a)gmail.com>: > > > Forwarding to the dev list in case people don't read the arch list. > > > > > > ---------- Forwarded message ---------- > > > From: Mister Dobalina <reebydobalina(a)yahoo.ca> > > > Date: Nov 1, 2007 10:27 AM > > > Subject: [arch] circular dependence in core > > > To: General Discusson about Arch Linux <arch(a)archlinux.org> > > > > > > > > > coreutils 6.9-3 -> depends on bash > > > > > > bash 3.2.025-1 -> depends on readline>=5.2 > > > > > > readline 5.2-4 -> depends on ncurses > > > > > > ncurses 5.6-4 -> depends on coreutils -> oops! > > > > > > > This was casused by this commit: > > http://cvs.archlinux.org/cgi-bin/viewcvs.cgi/base/ncurses/PKGBUILD.diff?r1=… > > I think we should revert it (because dependencies of other packages > > are fine and make more sense). > > > > And it was ncurses-5.6-4 package release that broke it. > http://cvs.archlinux.org/cgi-bin/viewcvs.cgi/base/ncurses/PKGBUILD.diff?r1=… > And we all missed this because pacman didn't complain when upgrading. > Well, no, this doesn't prevent pacman from installing the packages, only from sorting them, which is usually not critical. So pacman only prints a little warning in the --debug output when it detects a loop while sorting the packages, but that's all. Something like "dependency cycle detected" I don't know if this message should always be printed, on standard pacman output. There could maybe be a pacman option or an external tool for detecting dependencies cycles.

2 1

[pacman-dev] libalpm data structures
by Nagy Gabor 01 Nov '07

01 Nov '07

Hi! This is discussion-only (==no-patch) e-mail, mainly about code clean-up, so if you don't like that type of e-mails, please skip this. Xavier's compute_requiredby catch was the motivation of this e-mail: I never liked the following method: pmdepend_t *dep = alpm_splitdep(depend) /* char -> pmdepend_t conversion */ ...alpm_depcmp(pkg, dep)... FREE(dep) /* usually forgotten */ So I asked myself: Do we really need pmdepend_t struct? Why don't we use it in alpm_depcmp only ("internally")? So the depend-input of alpm_depcmp could be char* (and pmdepend_t should be disappear from libalpm API). Then I read the .h files of libalpm. My impressions: 1. We don't need pmdepend_t => pmdepmod_t. See above. This is mainly used in pmdepmissing_t which is used to collect missing dependencies (pmdepmissing_t is not needed here neither), and to print error/log messages (usually pmdepend_t -> char conversion is done here, too); where we could also use char. 2. We have pmconflict_t. Nice. So we don't need pmdeptype_t (in pmdepmissing_t). As we discussed with Xavier, pmconflict_t should be a symmetric structure: {target,ctarget} set [<=> alpm_strcmp ordered (target, ctarget) pair] instead of (target,ctarget) ordered pair) <- this is a pmconflict_t-helper-function problem only. Future plans: 3. I still want to kill pmsyncpkg_t => pmsynctype_t (the ugliest data struct of libalpm) 4. If my preferred universal transaction becomes true, we won't need pmtranstype_t. And of course, if we rip off some unneeded structures, we also rip off tons of unneeded associated helper functions. Personally, I want to make a patch for 1. and 2. So if you don't like the idea, let me know. However, I'm a bit unsure in 2.: should I keep target and ctarget as char, or I should use pmpkg_t* instead <- faster but more "dangerous". Bye, ngaba ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

5 24