On 01/10/14 17:05, Andrew Gregory wrote:
This is my attempt to clean up the behemoth extract_single_file function. In order to do this I have made the following user-visible changes that I would like feedback on:
- skip mtree, noupgrade, noextract checks for db files
- remove .pacorig support, use .pacnew instead
- extract backup files directly to .pacnew instead of .paccheck
This takes extract_single_file down from 340 lines to 225 and considerably reduces the number of nested conditionals
This patchset is great. Deal with the comments on patch 5/7 and rebase (sorry - my fault for the slow review...), and I will pull immediately.