On 04/22/2018 08:44 PM, Gabriel C wrote:
No, I think that's wrong. You're also removing the relocation information from the PIE binaries.
So explain why that is wrong and how is different to what is done right now .. If you say that is wrong then you say is wrong in general.
Well, uh, the whole point is that he's saying we should preserve the behavior with the new version of file?
Also how this removes realocation informations ? That would be then broken for <file 5.33 ,right ?
Did you run at least plain 'file' to see what file reports now no matter you have a shared lib , execuable or a static lib ?
On older versions of file, these were both treated as boring old application/x-sharedlib, and now on new versions of file it will be treated as exciting new application/x-pie-executable, which... has the exact same behavior as application/x-sharedlib.
Because heftig is trying to preserve the status quo, whereas you're suggesting we break with our current behavior and start treating pie executables like any other kind.
All this is literally in the commit message for this patch. So let's not waste time further discussing it.... If you object to the conceptual idea of using the same strip options on pie executables *and* shared libs, then by all means tell us why you object, but leave the file program out of it.
Also do tell us why we've been doing the wrong thing for quite some time now. ;)