On 05/15/2018 04:46 PM, Dave Reisner wrote:
On Sun, Mar 18, 2018 at 11:40:53AM +1000, Allan McRae wrote:
What makes this call to pacman not need to use run_pacman like the others?
Answer: run_pacman calls sudo, which means that a bare 'makepkg' will require elevated privileges.
Looking at 5698d7b66daa2a0bc99cab7a989cef1c806c3bf6 (1), `run_pacman` was already used for a `pacman -Q` prior to this patch, and looking at makepkg.sh.in l221 (2) it appears like run_pacman is currently whitelisting a handful of options only. This match should probably be improved (1) https://git.archlinux.org/pacman.git/commit/?id=5698d7b66daa2a0bc99cab7a989c... (2) https://git.archlinux.org/pacman.git/tree/scripts/makepkg.sh.in?id=HEAD#n221 -- Rob (coderobe) O< ascii ribbon campaign - stop html mail - www.asciiribbon.org