[pacman-dev] another case when pacman is asking for confirmation when it should not
There is another case where pacman-git asks for confirmation, when it should not. It is when removing packages. If running with makeworld --noconfirm --rmdeps the question will come to the log file, and never appear on the console, so you can wait forever wondering what is happening. *** src/pacman/remove.c~ Tue Dec 11 05:06:48 2007 --- src/pacman/remove.c Sun Dec 16 20:34:12 2007 *************** *** 155,161 **** list_display(_("Targets:"), lst); FREELIST(lst); /* get confirmation */ ! if(yesno(_("\nDo you want to remove these packages? [Y/n] ")) == 0) { remove_cleanup(); FREELIST(finaltargs); return(1); --- 155,161 ---- list_display(_("Targets:"), lst); FREELIST(lst); /* get confirmation */ ! if(!config->noconfirm && yesno(_("\nDo you want to remove these packages? [Y/n] ")) == 0) { remove_cleanup(); FREELIST(finaltargs); return(1);
On Sat, Dec 29, 2007 at 10:52:53AM +0100, Karolina Lindqvist <karolina.lindqvist@kramnet.se> wrote:
There is another case where pacman-git asks for confirmation, when it should not. It is when removing packages. If running with makeworld --noconfirm --rmdeps the question will come to the log file, and never appear on the console, so you can wait forever wondering what is happening.
please use git diff or diff -u to generate the patch, context diffs are hard to read ;) thanks, - VMiklos
On Dec 29, 2007 8:00 AM, Miklos Vajna <vmiklos@frugalware.org> wrote:
On Sat, Dec 29, 2007 at 10:52:53AM +0100, Karolina Lindqvist <karolina.lindqvist@kramnet.se> wrote:
There is another case where pacman-git asks for confirmation, when it should not. It is when removing packages. If running with makeworld --noconfirm --rmdeps the question will come to the log file, and never appear on the console, so you can wait forever wondering what is happening.
please use git diff or diff -u to generate the patch, context diffs are hard to read ;)
I was going to say the same, except for the fact that this is a one line change so isn't all that hard to read 8) Still, unified diffs are superior.
participants (3)
-
Aaron Griffin
-
Karolina Lindqvist
-
Miklos Vajna