[arch-commits] Commit in thunderbird/trunk (26 files)

Jan de Groot jan at jgc.homeip.net
Thu May 22 17:24:39 EDT 2008


On Thu, 2008-05-22 at 16:05 -0500, Aaron Griffin wrote:
> On Thu, May 22, 2008 at 3:59 PM, Jan de Groot <jgc at archlinux.org> wrote:
> >    Date: Thursday, May 22, 2008 @ 16:59:42
> >  Author: jgc
> > Revision: 1915
> >
> > upgpkg: thunderbird 2.0.0.14-2
> >    Remove a shitload of patches. Remove CFLAGS and CXXFLAGS. Fixes attachment issue with gcc 4.3. See http://www.0xdeadbeef.com/weblog/?p=368 and the linked bugreports for CFLAGS and CXXFLAGS removal reasons. Added some extra statements to mozconfig to remove dependencies on gnome
> >
> > Modified:
> >  thunderbird/trunk/PKGBUILD
> >  thunderbird/trunk/mozconfig
> > Deleted:
> >  thunderbird/trunk/firefox-1.5-bullet-bill.patch
> >  thunderbird/trunk/firefox-1.5-new-gtkim.patch
> >  thunderbird/trunk/firefox-1.5-pango-cursor-position.patch
> >  thunderbird/trunk/firefox-1.5-pango-justified-range.patch
> >  thunderbird/trunk/firefox-1.5-pango-mathml.patch
> >  thunderbird/trunk/firefox-1.5-pango-underline.patch
> >  thunderbird/trunk/firefox-1.5-theme-change.patch
> >  thunderbird/trunk/firefox-1.5-xft-rangewidth.patch
> >  thunderbird/trunk/firefox-1.5.0.10-nss-system-nspr.patch
> >  thunderbird/trunk/firefox-1.5.0.10-with-system-nss.patch

No idea why those are here still, version states 1.5, half of them were
not applied anymore. Please cleanup patches when no longer using them...

> >  thunderbird/trunk/firefox-2.0-add-ldflags.patch
This one was duplicate, there's another patch that stayed that fixes the
same bug...

> >  thunderbird/trunk/firefox-2.0-dnd.patch
old patch, not needed anymore

> >  thunderbird/trunk/firefox-2.0-pango-ligatures.patch
> >  thunderbird/trunk/firefox-2.0-pango-printing.patch
all stuff with pango... half of the pango crap doesn't apply anymore so
I assume this one isn't needed anymore

> >  thunderbird/trunk/firefox-2.0.0.4-undo-uriloader.patch
Ah, nice, a fix for xulrunner/firefox so it works better with epiphany
when embedding libgtkmozembed.so... useful for thunderbird :P

> >  thunderbird/trunk/firefox-bug-380558-arch.patch
No idea

> >  thunderbird/trunk/firefox-nopangoxft.patch
Deprecated patch

> >  thunderbird/trunk/firefox-visibility.patch
Replaced with a simple echo to mozconfig

> >  thunderbird/trunk/iceweasel_2.0.0.12-1_part.patch
WTF is this thing? why was it ever added. No idea about where to get an
update, no reference to what it actually is.

> >  thunderbird/trunk/launcher.patch
No longer needed. The patch is already applied upstream, but this one
still applies clean because it was applied a few lines below the
official fix

> >  thunderbird/trunk/moz310924.patch
> >  thunderbird/trunk/moz325644.patch
Two nice epiphany fixes

> >  thunderbird/trunk/mozilla-firefox-1.0-lang.patch
We have a newer -lang patch

> >  thunderbird/trunk/mozilla-firefox-2.0.0.6-fixgtk212.patch
Already fixed upstream

> 
> Oh my god! /me blinks

Yes, a shitload of patches. Didn't you see I did the same to xulrunner a
while ago? I don't remember fixing firefox, but patch cleanup and
CFLAGS/CXXFLAGS removal is also on my todo list for that one.
CFLAGS/CXXFLAGS removal should be done to xulrunner also to speed up
epiphany (yes! not optimizing mozilla is faster: mozilla has tuned their
CFLAGS for each and every small project inside the source, setting
CFLAGS overrides those optimizations).

Patching is good to fix bugs... but when you don't know what you're
patching anymore, it's bad and patches should be removed in that case.





More information about the arch-commits mailing list