[arch-commits] Commit in htop/trunk (5 files)

[Andrea Scarpino]

    Date: Wednesday, October 19, 2011 @ 05:58:29
  Author: andrea
Revision: 140789

upgpkg: htop 0.9-3

Fix sefault in small terminals; Enable cgroup support; Add lsof and trace optional dependencies

Added:
  htop/trunk/fix-segfault-small-terminal.patch
  htop/trunk/fix-sort-key-bug.patch
Modified:
  htop/trunk/ChangeLog
  htop/trunk/PKGBUILD
Deleted:
  htop/trunk/htop.c.patch

-----------------------------------+
 ChangeLog                         |    5 +++++
 PKGBUILD                          |   30 ++++++++++++++++++++----------
 fix-segfault-small-terminal.patch |   24 ++++++++++++++++++++++++
 fix-sort-key-bug.patch            |   15 +++++++++++++++
 htop.c.patch                      |   15 ---------------
 5 files changed, 64 insertions(+), 25 deletions(-)

Modified: ChangeLog
===================================================================
--- ChangeLog	2011-10-19 09:41:22 UTC (rev 140788)
+++ ChangeLog	2011-10-19 09:58:29 UTC (rev 140789)
@@ -1,3 +1,8 @@
+2011-10-19  Andrea Scarpino <andrea at archlinux.org>
+    * Enable cgroup support (FS#26155)
+    * Add lsof and strace optional depends (FS#25778)
+    * Fix crash when column is less than 40 (closes FS#25823)
+
 2011-05-17  Angel Velasquez <angvp at archlinux.org>
 	* Added patch to fix --sort-key (closes FS#23224)
 

Modified: PKGBUILD
===================================================================
--- PKGBUILD	2011-10-19 09:41:22 UTC (rev 140788)
+++ PKGBUILD	2011-10-19 09:58:29 UTC (rev 140789)
@@ -5,31 +5,41 @@
 
 pkgname=htop
 pkgver=0.9
-pkgrel=2
+pkgrel=3
 pkgdesc="Interactive process viewer"
 arch=('i686' 'x86_64')
 url="http://htop.sourceforge.net/"
 license=('GPL')
 depends=('ncurses')
 makedepends=('python2')
+optdepends=('lsof' 'strace')
 options=('!emptydirs')
 changelog=ChangeLog
-source=(http://downloads.sourceforge.net/htop/${pkgname}-${pkgver}.tar.gz
-        htop.c.patch)
+source=(http://downloads.sourceforge.net/${pkgname}/${pkgname}-${pkgver}.tar.gz
+        'fix-sort-key-bug.patch'
+        'fix-segfault-small-terminal.patch')
 md5sums=('7c5507f35f363f3f40183a2ba3c561f8'
-         '750e8ad8476c5d9738da2a2bc7a7c2b6')
+         '750e8ad8476c5d9738da2a2bc7a7c2b6'
+         'd93e39c9662522367dc3a73cc3057039')
 
 build() {
-	cd ${srcdir}/${pkgname}-${pkgver}
+	cd "${srcdir}/${pkgname}-${pkgver}"
+
 	sed -i 's|ncursesw/curses.h|curses.h|' RichString.h RichString.c configure 
 	sed -i 's|python|python2|' scripts/MakeHeader.py
-    patch -Np0 -i $srcdir/htop.c.patch
-	./configure --prefix=/usr --enable-unicode --enable-openvz \
-	    --enable-vserver 
+
+    patch -Np0 -i "${srcdir}/fix-sort-key-bug.patch"
+    patch -p1 -i "${srcdir}/fix-segfault-small-terminal.patch"
+
+	./configure --prefix=/usr \
+      --enable-unicode \
+      --enable-openvz \
+	  --enable-vserver \
+      --enable-cgroup
 	make 
 }
 
 package() {
-	cd ${srcdir}/${pkgname}-${pkgver}
-	make DESTDIR=${pkgdir} install 
+	cd "${srcdir}/${pkgname}-${pkgver}"
+	make DESTDIR="${pkgdir}" install 
 }

Added: fix-segfault-small-terminal.patch
===================================================================
--- fix-segfault-small-terminal.patch	                        (rev 0)
+++ fix-segfault-small-terminal.patch	2011-10-19 09:58:29 UTC (rev 140789)
@@ -0,0 +1,24 @@
+--- trunk/Meter.c	2011/08/26 20:52:35	229
++++ trunk/Meter.c	2011/08/26 20:55:09	230
+@@ -264,13 +264,19 @@
+    
+    w--;
+    x++;
+-   char bar[w];
++
++   if (w < 1) {
++      attrset(CRT_colors[RESET_COLOR]);
++      return;
++   }
++   char bar[w + 1];
+    
+    int blockSizes[10];
+    for (int i = 0; i < w; i++)
+       bar[i] = ' ';
+ 
+-   sprintf(bar + (w-strlen(buffer)), "%s", buffer);
++   const size_t barOffset = w - MIN(strlen(buffer), w);
++   snprintf(bar + barOffset, w - barOffset + 1, "%s", buffer);
+ 
+    // First draw in the bar[] buffer...
+    double total = 0.0;

Added: fix-sort-key-bug.patch
===================================================================
--- fix-sort-key-bug.patch	                        (rev 0)
+++ fix-sort-key-bug.patch	2011-10-19 09:58:29 UTC (rev 140789)
@@ -0,0 +1,15 @@
+From: Roman Kosenko <madkite at gmail.com>
+Date: Thu, 10 Mar 2011 16:23:53 +0200
+Subject: [PATCH] Fix stupid bug with --sort-key
+
+--- htop.c.old	2010-11-24 20:45:38.000000000 +0200
++++ htop.c	2011-03-10 16:32:18.473716667 +0200
+@@ -282,7 +282,7 @@
+             printVersionFlag();
+             break;
+          case 's':
+-            if (strcmp(optarg, "help")) {
++            if (!strcmp(optarg, "help")) {
+                for (int j = 1; j < LAST_PROCESSFIELD; j++)
+                   printf ("%s\n", Process_fieldNames[j]);
+                exit(0);

Deleted: htop.c.patch
===================================================================
--- htop.c.patch	2011-10-19 09:41:22 UTC (rev 140788)
+++ htop.c.patch	2011-10-19 09:58:29 UTC (rev 140789)
@@ -1,15 +0,0 @@
-From: Roman Kosenko <madkite at gmail.com>
-Date: Thu, 10 Mar 2011 16:23:53 +0200
-Subject: [PATCH] Fix stupid bug with --sort-key
-
---- htop.c.old	2010-11-24 20:45:38.000000000 +0200
-+++ htop.c	2011-03-10 16:32:18.473716667 +0200
-@@ -282,7 +282,7 @@
-             printVersionFlag();
-             break;
-          case 's':
--            if (strcmp(optarg, "help")) {
-+            if (!strcmp(optarg, "help")) {
-                for (int j = 1; j < LAST_PROCESSFIELD; j++)
-                   printf ("%s\n", Process_fieldNames[j]);
-                exit(0);