[arch-commits] Commit in patch/trunk (2 files)

[Evangelos Foutras]

    Date: Monday, December 31, 2012 @ 08:02:33
  Author: foutrelis
Revision: 173994

upgpkg: patch 2.7.1-2

Fix segfault on non-numeric strip-count or nonexistent directory passed to -d.

Added:
  patch/trunk/patch-2.7.1-initialize-data-structures-early-enough.patch
Modified:
  patch/trunk/PKGBUILD

-----------------------------------------------------------+
 PKGBUILD                                                  |   15 +-
 patch-2.7.1-initialize-data-structures-early-enough.patch |   81 ++++++++++++
 2 files changed, 93 insertions(+), 3 deletions(-)

Modified: PKGBUILD
===================================================================
--- PKGBUILD	2012-12-31 12:25:23 UTC (rev 173993)
+++ PKGBUILD	2012-12-31 13:02:33 UTC (rev 173994)
@@ -4,7 +4,7 @@
 
 pkgname=patch
 pkgver=2.7.1
-pkgrel=1
+pkgrel=2
 pkgdesc="A utility to apply patch files to original sources"
 arch=('i686' 'x86_64')
 url="http://www.gnu.org/software/patch/patch.html"
@@ -13,12 +13,21 @@
 depends=('glibc')
 makedepends=('ed')
 optdepends=('ed: for patch -e functionality')
-source=(ftp://ftp.gnu.org/gnu/${pkgname}/${pkgname}-${pkgver}.tar.xz{,.sig})
+source=(ftp://ftp.gnu.org/gnu/${pkgname}/${pkgname}-${pkgver}.tar.xz{,.sig}
+        patch-2.7.1-initialize-data-structures-early-enough.patch)
 md5sums=('e9ae5393426d3ad783a300a338c09b72'
-         'b12189e0de3cb2af25268441647ec517')
+         'b12189e0de3cb2af25268441647ec517'
+         'dc6367a7cd49933d4006c246789e98da')
 
 build() {
   cd ${srcdir}/${pkgname}-${pkgver}
+
+  # Fix segfault on non-numeric strip-count
+  # (also segfaults on nonexistent directory passed to -d)
+  # http://savannah.gnu.org/bugs/?37500
+  patch -Np1 -i \
+    $srcdir/patch-2.7.1-initialize-data-structures-early-enough.patch
+
   ./configure --prefix=/usr
   make
 }

Added: patch-2.7.1-initialize-data-structures-early-enough.patch
===================================================================
--- patch-2.7.1-initialize-data-structures-early-enough.patch	                        (rev 0)
+++ patch-2.7.1-initialize-data-structures-early-enough.patch	2012-12-31 13:02:33 UTC (rev 173994)
@@ -0,0 +1,81 @@
+From 291ec175812b7ba291d124e4cf2fbf9efec590c8 Mon Sep 17 00:00:00 2001
+From: Andreas Gruenbacher <agruen at linbit.com>
+Date: Thu, 4 Oct 2012 12:33:09 +0200
+Subject: [PATCH] Initialize data structures early enough
+
+* src/patch.c (main): Initialize data structures early enough, before error
+paths can access them.
+* tests/bad-usage: Test bad command line usage.
+* tests/Makefile.am (TESTS): Add bad-usage here.
+---
+ src/patch.c       |  8 ++++----
+ tests/Makefile.am |  1 +
+ tests/bad-usage   | 18 ++++++++++++++++++
+ 3 files changed, 23 insertions(+), 4 deletions(-)
+ create mode 100644 tests/bad-usage
+
+diff --git a/src/patch.c b/src/patch.c
+index 828943b..0255fbb 100644
+--- a/src/patch.c
++++ b/src/patch.c
+@@ -150,6 +150,10 @@ main (int argc, char **argv)
+     else if ((version_control = getenv ("VERSION_CONTROL")))
+       version_control_context = "$VERSION_CONTROL";
+ 
++    init_backup_hash_table ();
++    init_files_to_delete ();
++    init_files_to_output ();
++
+     /* parse switches */
+     Argc = argc;
+     Argv = argv;
+@@ -162,10 +166,6 @@ main (int argc, char **argv)
+     if (make_backups | backup_if_mismatch)
+       backup_type = get_version (version_control_context, version_control);
+ 
+-    init_backup_hash_table ();
+-    init_files_to_delete ();
+-    init_files_to_output ();
+-
+     init_output (&outstate);
+     if (outfile)
+       outstate.ofp = open_outfile (outfile);
+diff --git a/tests/Makefile.am b/tests/Makefile.am
+index 02fc6de..5cea52d 100644
+--- a/tests/Makefile.am
++++ b/tests/Makefile.am
+@@ -20,6 +20,7 @@ TESTS = \
+ 	asymmetric-hunks \
+ 	backup-prefix-suffix \
+ 	bad-filenames \
++	bad-usage \
+ 	concat-git-diff \
+ 	copy-rename \
+ 	corrupt-reject-files \
+diff --git a/tests/bad-usage b/tests/bad-usage
+new file mode 100644
+index 0000000..022eeda
+--- /dev/null
++++ b/tests/bad-usage
+@@ -0,0 +1,18 @@
++# Copyright (C) 2009, 2011-2012 Free Software Foundation, Inc.
++#
++# Copying and distribution of this file, with or without modification,
++# in any medium, are permitted without royalty provided the copyright
++# notice and this notice are preserved.
++
++. $srcdir/test-lib.sh
++
++require_cat
++use_local_patch
++use_tmpdir
++
++# ==============================================================
++
++check 'patch -px || echo "status: $?"' <<EOF
++$PATCH: **** strip count x is not a number
++status: 2
++EOF
+-- 
+1.8.0.3
+