[arch-commits] Commit in chromium/trunk (2 files)

Evangelos Foutras foutrelis at archlinux.org
Mon Jun 4 23:35:12 UTC 2018


    Date: Monday, June 4, 2018 @ 23:35:07
  Author: foutrelis
Revision: 325870

Add patch for upstream issue 707721 (FS#53544)

Dialogs were invisible when browser was maximized on second HIDPI screen.

Added:
  chromium/trunk/x11-fix-mixup-between-DIP-pixel-coordinates.patch
Modified:
  chromium/trunk/PKGBUILD

---------------------------------------------------+
 PKGBUILD                                          |    5 ++
 x11-fix-mixup-between-DIP-pixel-coordinates.patch |   40 ++++++++++++++++++++
 2 files changed, 45 insertions(+)

Modified: PKGBUILD
===================================================================
--- PKGBUILD	2018-06-04 22:32:34 UTC (rev 325869)
+++ PKGBUILD	2018-06-04 23:35:07 UTC (rev 325870)
@@ -25,6 +25,7 @@
 source=(https://commondatastorage.googleapis.com/chromium-browser-official/$pkgname-$pkgver.tar.xz
         chromium-launcher-$_launcher_ver.tar.gz::https://github.com/foutrelis/chromium-launcher/archive/v$_launcher_ver.tar.gz
         remove-dependency-on-ffmpeg-internals-for-start-time.patch
+        x11-fix-mixup-between-DIP-pixel-coordinates.patch
         chromium-ffmpeg-r1.patch
         chromium-widevine-r2.patch
         chromium-skia-harmony.patch)
@@ -31,6 +32,7 @@
 sha256sums=('d5ee63932ff1c8c4a5f69c834f6577e7127b416681eddd23bc54886caffd770d'
             '04917e3cd4307d8e31bfb0027a5dce6d086edb10ff8a716024fbb8bb0c7dccf1'
             '2cc80f5ed8a9b42495a0f3ab3c1bae026b9081972269a1b6d407331d33f7d257'
+            'e2c2754536243a60fa70541bbd4121715eccd83caa8f1fb1873bd994cd81f871'
             'aa885330bc4180b78d915f9dfdfc3210038a0acab7b16735ea9828ab6a633bde'
             '02c69bb3954087db599def7f5b6d65cf8f7cf2ed81dfbdaa4bb7b51863b4df15'
             'feca54ab09ac0fc9d0626770a6b899a6ac5a12173c7d0c1005bc3964ec83e7b3')
@@ -80,6 +82,9 @@
   # https://crbug.com/731766
   patch -Np1 -i ../remove-dependency-on-ffmpeg-internals-for-start-time.patch
 
+  # https://crbug.com/707721
+  patch -Np1 -i ../x11-fix-mixup-between-DIP-pixel-coordinates.patch
+
   # https://crbug.com/skia/6663#c10
   patch -Np4 -i ../chromium-skia-harmony.patch
 

Added: x11-fix-mixup-between-DIP-pixel-coordinates.patch
===================================================================
--- x11-fix-mixup-between-DIP-pixel-coordinates.patch	                        (rev 0)
+++ x11-fix-mixup-between-DIP-pixel-coordinates.patch	2018-06-04 23:35:07 UTC (rev 325870)
@@ -0,0 +1,40 @@
+From 2752a03ba6435130848aa620b7ab4246eec2f77a Mon Sep 17 00:00:00 2001
+From: Tom Anderson <thomasanderson at chromium.org>
+Date: Mon, 4 Jun 2018 22:09:08 +0000
+Subject: [PATCH] X11: Fix mixup between DIP/pixel coordinates
+
+BUG=707721
+R=sky
+
+Change-Id: Ibbbff9c2c815700324f553a3b66e878f76938534
+Reviewed-on: https://chromium-review.googlesource.com/1083692
+Reviewed-by: Scott Violet <sky at chromium.org>
+Commit-Queue: Thomas Anderson <thomasanderson at chromium.org>
+Cr-Commit-Position: refs/heads/master@{#564261}
+---
+ ui/views/widget/desktop_aura/desktop_screen_x11.cc | 9 +++++++--
+ 1 file changed, 7 insertions(+), 2 deletions(-)
+
+diff --git a/ui/views/widget/desktop_aura/desktop_screen_x11.cc b/ui/views/widget/desktop_aura/desktop_screen_x11.cc
+index 8fd5d379d344..e90710c2c39c 100644
+--- a/ui/views/widget/desktop_aura/desktop_screen_x11.cc
++++ b/ui/views/widget/desktop_aura/desktop_screen_x11.cc
+@@ -216,8 +216,13 @@ display::Display DesktopScreenX11::GetDisplayNearestWindow(
+   if (host) {
+     DesktopWindowTreeHostX11* rwh = DesktopWindowTreeHostX11::GetHostForXID(
+         host->GetAcceleratedWidget());
+-    if (rwh)
+-      return GetDisplayMatching(rwh->GetX11RootWindowBounds());
++    if (rwh) {
++      const float scale = 1.0f / GetDeviceScaleFactor();
++      const gfx::Rect pixel_rect = rwh->GetX11RootWindowBounds();
++      return GetDisplayMatching(
++          gfx::Rect(gfx::ScaleToFlooredPoint(pixel_rect.origin(), scale),
++                    gfx::ScaleToCeiledSize(pixel_rect.size(), scale)));
++    }
+   }
+ 
+   return GetPrimaryDisplay();
+-- 
+2.17.1
+



More information about the arch-commits mailing list