[arch-commits] Commit in perl/trunk (PKGBUILD)

Florian Pritz bluewind at archlinux.org
Fri Jan 3 14:22:50 UTC 2020


    Date: Friday, January 3, 2020 @ 14:22:50
  Author: bluewind
Revision: 372510

Quote unquoted variables

Modified:
  perl/trunk/PKGBUILD

----------+
 PKGBUILD |   28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

Modified: PKGBUILD
===================================================================
--- PKGBUILD	2020-01-03 14:10:26 UTC (rev 372509)
+++ PKGBUILD	2020-01-03 14:22:50 UTC (rev 372510)
@@ -128,7 +128,7 @@
           'perl-version=0.9924'
           'perl-xsloader=0.30')
 # Add your own provides here
-provides=(${provides[@]})
+provides=("${provides[@]}")
 source=(https://www.cpan.org/src/5.0/perl-${pkgver}.tar.xz
         perlbin.sh
         perlbin.csh
@@ -145,11 +145,11 @@
 # https://www.cpan.org/src/5.0/perl-$pkgver.tar.xz.sha256.txt
 
 prepare() {
-  cd ${srcdir}/${pkgname}-${pkgver}
+  cd "${srcdir}/${pkgname}-${pkgver}"
 }
 
 build() {
-  cd ${srcdir}/${pkgname}-${pkgver}
+  cd "${srcdir}/${pkgname}-${pkgver}"
 
   if [ "${CARCH}" = "x86_64" ]; then
     # for x86_64
@@ -177,13 +177,13 @@
 }
 
 check() {
-  cd ${srcdir}/${pkgname}-${pkgver}
-  TEST_JOBS=$(echo $MAKEFLAGS | sed 's/.*-j\([0-9][0-9]*\).*/\1/') make test_harness
+  cd "${srcdir}/${pkgname}-${pkgver}"
+  TEST_JOBS=$(echo "$MAKEFLAGS" | sed 's/.*-j\([0-9][0-9]*\).*/\1/') make test_harness
 #  make test
 }
 
 package() {
-  cd ${srcdir}/${pkgname}-${pkgver}
+  cd "${srcdir}/${pkgname}-${pkgver}"
   make DESTDIR="$pkgdir" install
 
   ### Perl Settings ###
@@ -193,20 +193,20 @@
   sed -e '/^man1ext=/ s/1perl/1p/' -e '/^man3ext=/ s/3perl/3pm/' \
       -e "/^cf_email=/ s/'.*'/''/" \
       -e "/^perladmin=/ s/'.*'/''/" \
-      -i ${pkgdir}/usr/lib/perl5/$_baseversion/core_perl/Config_heavy.pl
+      -i "${pkgdir}/usr/lib/perl5/$_baseversion/core_perl/Config_heavy.pl"
 
   ### CPAN Settings ###
   # Set CPAN default config to use the site directories.
   sed -e '/(makepl_arg =>/   s/""/"INSTALLDIRS=site"/' \
       -e '/(mbuildpl_arg =>/ s/""/"installdirs=site"/' \
-      -i ${pkgdir}/usr/share/perl5/core_perl/CPAN/FirstTime.pm
+      -i "${pkgdir}/usr/share/perl5/core_perl/CPAN/FirstTime.pm"
 
   # Profile script to set paths to perl scripts.
-  install -D -m644 ${srcdir}/perlbin.sh \
-                   ${pkgdir}/etc/profile.d/perlbin.sh
+  install -D -m644 "${srcdir}/perlbin.sh" \
+                   "${pkgdir}/etc/profile.d/perlbin.sh"
   # Profile script to set paths to perl scripts on csh. (FS#22441)
-  install -D -m644 ${srcdir}/perlbin.csh \
-                  ${pkgdir}/etc/profile.d/perlbin.csh
+  install -D -m644 "${srcdir}/perlbin.csh" \
+                  "${pkgdir}/etc/profile.d/perlbin.csh"
   # Profile script to set paths to perl scripts on fish. (FS#51191)
   install -D -m 755 "$srcdir/perlbin.fish" \
                   "$pkgdir/usr/share/fish/vendor_conf.d/perlbin.fish"
@@ -222,6 +222,6 @@
   install -D -m755 -t "$pkgdir/usr/share/libalpm/scripts" "$srcdir/detect-old-perl-modules.sh"
   install -D -m644 -t "$pkgdir/usr/share/libalpm/hooks" "$srcdir/detect-old-perl-modules.hook"
 
-  find $pkgdir -name perllocal.pod -delete
-  find $pkgdir -name .packlist -delete
+  find "$pkgdir" -name perllocal.pod -delete
+  find "$pkgdir" -name .packlist -delete
 }



More information about the arch-commits mailing list