[arch-commits] Commit in xfdesktop/trunk (2 files)

[Evangelos Foutras]

    Date: Friday, May 8, 2020 @ 21:19:57
  Author: foutrelis
Revision: 382809

upgpkg: xfdesktop 4.14.2-2: fix a memory leak (FS#66589)

Added:
  xfdesktop/trunk/fix-memory-leak-when-reconnecting-DP-monitor.patch
Modified:
  xfdesktop/trunk/PKGBUILD

----------------------------------------------------+
 PKGBUILD                                           |    9 +++--
 fix-memory-leak-when-reconnecting-DP-monitor.patch |   34 +++++++++++++++++++
 2 files changed, 40 insertions(+), 3 deletions(-)

Modified: PKGBUILD
===================================================================
--- PKGBUILD	2020-05-08 21:08:21 UTC (rev 382808)
+++ PKGBUILD	2020-05-08 21:19:57 UTC (rev 382809)
@@ -3,7 +3,7 @@
 
 pkgname=xfdesktop
 pkgver=4.14.2
-pkgrel=1
+pkgrel=2
 pkgdesc="A desktop manager for Xfce"
 arch=('x86_64')
 url="https://www.xfce.org/"
@@ -11,11 +11,14 @@
 groups=('xfce4')
 depends=('libxfce4ui' 'libwnck3' 'exo' 'thunar' 'garcon' 'hicolor-icon-theme')
 makedepends=('intltool')
-source=(https://archive.xfce.org/src/xfce/$pkgname/${pkgver%.*}/$pkgname-$pkgver.tar.bz2)
-sha256sums=('a30534461fea907f969f608a11c84be0b1aaad687c591c32cd56a9d274ea3e74')
+source=(https://archive.xfce.org/src/xfce/$pkgname/${pkgver%.*}/$pkgname-$pkgver.tar.bz2
+        fix-memory-leak-when-reconnecting-DP-monitor.patch)
+sha256sums=('a30534461fea907f969f608a11c84be0b1aaad687c591c32cd56a9d274ea3e74'
+            'e6e14ec1d3fd594b0003b3724cc039d882c5f85ee0d9ece7c873d57310e8aec9')
 
 prepare() {
   cd "$srcdir/$pkgname-$pkgver"
+  patch -Np1 -i ../fix-memory-leak-when-reconnecting-DP-monitor.patch
 }
 
 build() {

Added: fix-memory-leak-when-reconnecting-DP-monitor.patch
===================================================================
--- fix-memory-leak-when-reconnecting-DP-monitor.patch	                        (rev 0)
+++ fix-memory-leak-when-reconnecting-DP-monitor.patch	2020-05-08 21:19:57 UTC (rev 382809)
@@ -0,0 +1,34 @@
+From f3f9bdb5a9162480ba1a892d37859321f37c4d51 Mon Sep 17 00:00:00 2001
+From: Jan Ziak <0xe2.0x9a.0x9b at gmail.com>
+Date: Sat, 11 Apr 2020 15:43:55 +0200
+Subject: [PATCH] Fix memory leak when reconnecting DP monitor (Bug #16314)
+
+Signed-off-by: Jan Ziak <0xe2.0x9a.0x9b at gmail.com>
+---
+ src/xfce-backdrop.c | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+diff --git a/src/xfce-backdrop.c b/src/xfce-backdrop.c
+index bd9180e6..955e51f8 100644
+--- a/src/xfce-backdrop.c
++++ b/src/xfce-backdrop.c
+@@ -1599,6 +1599,11 @@ xfce_backdrop_image_data_release(XfceBackdropImageData *image_data)
+ 
+     if(image_data->loader)
+         g_object_unref(image_data->loader);
++
++    if(image_data->backdrop) {
++        g_object_unref(image_data->backdrop);
++        image_data->backdrop = NULL;
++    }
+ }
+ 
+ /**
+@@ -1671,6 +1676,7 @@ xfce_backdrop_generate_async(XfceBackdrop *backdrop)
+     backdrop->priv->image_data = image_data;
+ 
+     image_data->backdrop = backdrop;
++    g_object_ref(backdrop);
+     image_data->loader = gdk_pixbuf_loader_new();
+     image_data->cancellable = g_cancellable_new();
+     image_data->image_buffer = g_new0(guchar, XFCE_BACKDROP_BUFFER_SIZE);