[arch-commits] Commit in chromium/trunk (2 files)

[Evangelos Foutras]

    Date: Thursday, October 22, 2020 @ 08:25:31
  Author: foutrelis
Revision: 398722

upgpkg: chromium 86.0.4240.111-2: fix mouse focus near window edges

Added:
  chromium/trunk/xproto-fix-underflow-in-Fp1616ToDouble.patch
Modified:
  chromium/trunk/PKGBUILD

----------------------------------------------+
 PKGBUILD                                     |    5 ++-
 xproto-fix-underflow-in-Fp1616ToDouble.patch |   37 +++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 1 deletion(-)

Modified: PKGBUILD
===================================================================
--- PKGBUILD	2020-10-22 00:29:38 UTC (rev 398721)
+++ PKGBUILD	2020-10-22 08:25:31 UTC (rev 398722)
@@ -5,7 +5,7 @@
 
 pkgname=chromium
 pkgver=86.0.4240.111
-pkgrel=1
+pkgrel=2
 _launcher_ver=6
 _gcc_patchset=6
 pkgdesc="A web browser built for speed, simplicity, and security"
@@ -32,6 +32,7 @@
         only-fall-back-to-the-i965-driver-if-we-re-on-iHD.patch
         remove-dead-reloc-in-nonalloc-LD-flags.patch
         check-for-enable-accelerated-video-decode-on-Linux.patch
+        xproto-fix-underflow-in-Fp1616ToDouble.patch
         chromium-skia-harmony.patch)
 sha256sums=('f27bdb02ebf3c48abe054c73f1ae57e22a22535ea34f5edf8693ab8432a7c717'
             '04917e3cd4307d8e31bfb0027a5dce6d086edb10ff8a716024fbb8bb0c7dccf1'
@@ -40,6 +41,7 @@
             '7514c6c81a64a5457b66494a366fbb39005563eecc48d1a39033dd06aec4e300'
             '7cace84d7494190e7882d3e637820646ec8d64808f0a2128c515bd44991a3790'
             '03d03a39b2afa40083eb8ccb9616a51619f71da92348effc8ee289cbda10128b'
+            '1ec617b362bf97cce4254debd04d8396f17dec0ae1071b52ec8c1c3d86dbd322'
             '771292942c0901092a402cc60ee883877a99fb804cb54d568c8c6c94565a48e1')
 
 # Possible replacements are listed in build/linux/unbundle/replace_gn_files.py
@@ -93,6 +95,7 @@
   patch -Np1 -i ../only-fall-back-to-the-i965-driver-if-we-re-on-iHD.patch
   patch -Np1 -i ../remove-dead-reloc-in-nonalloc-LD-flags.patch
   patch -Np1 -i ../check-for-enable-accelerated-video-decode-on-Linux.patch
+  patch -Np1 -i ../xproto-fix-underflow-in-Fp1616ToDouble.patch
 
   # Fixes for building with libstdc++ instead of libc++
   patch -Np1 -i ../patches/chromium-86-nearby-include.patch

Added: xproto-fix-underflow-in-Fp1616ToDouble.patch
===================================================================
--- xproto-fix-underflow-in-Fp1616ToDouble.patch	                        (rev 0)
+++ xproto-fix-underflow-in-Fp1616ToDouble.patch	2020-10-22 08:25:31 UTC (rev 398722)
@@ -0,0 +1,37 @@
+From 5ade494a9966c7a9675af86dc42aca62fb4d806d Mon Sep 17 00:00:00 2001
+From: Tom Anderson <thomasanderson at chromium.org>
+Date: Wed, 21 Oct 2020 22:02:35 +0000
+Subject: [PATCH] [XProto] Fix underflow in Fp1616ToDouble
+
+x11::Input::Fp1616 should be treated as a signed integer, otherwise
+-1 will underflow to 65535.  When dragging a scrollbar, this would
+cause the scrollbar to snap to the bottom when the cursor is dragged
+above the window's y=0 coordinate.  Verified that the issue is fixed
+after this CL.
+
+BUG=1139623,1136352
+R=sky
+
+Change-Id: Ie318006ceadde9b9ce3e267fb453ddeba0e81da0
+Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485620
+Auto-Submit: Thomas Anderson <thomasanderson at chromium.org>
+Commit-Queue: Scott Violet <sky at chromium.org>
+Reviewed-by: Scott Violet <sky at chromium.org>
+Cr-Commit-Position: refs/heads/master@{#819538}
+---
+ ui/events/x/events_x_utils.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/ui/events/x/events_x_utils.cc b/ui/events/x/events_x_utils.cc
+index 3010db5f40c..856dfb221e7 100644
+--- a/ui/events/x/events_x_utils.cc
++++ b/ui/events/x/events_x_utils.cc
+@@ -376,7 +376,7 @@ base::TimeTicks TimeTicksFromXEvent(const x11::Event& xev) {
+ 
+ // This is ported from libxi's FP1616toDBL in XExtInt.c
+ double Fp1616ToDouble(x11::Input::Fp1616 x) {
+-  auto x32 = static_cast<uint32_t>(x);
++  auto x32 = static_cast<int32_t>(x);
+   return x32 * 1.0 / (1 << 16);
+ }
+