[arch-dev-public] [PATCH] initscripts: Add a splash support

[Damir Perisa]

Sunday 04 November 2007, Thomas Bächler wrote:
 | I added a splash branch to initscripts and applied the patch. We
 | can merge that once the patch is finalized:
 | http://projects.archlinux.org/git/?p=initscripts.git;a=shortlog;h=
 |splash

http://projects.archlinux.org/git/?p=initscripts.git;a=commitdiff;h=ad804da15be2f52960ac45a967826e1d9ae5fc77

+if [ -n "${SPLASH}" -a -x "/sbin/${SPLASH}_wrapper" ]; then
+       source /etc/$SPLASH.conf
+       source /etc/rc.d/$SPLASH-functions
+       splash_wrapper() {
+                /sbin/${SPLASH}_wrapper $@
+       }
+else
+       splash_wrapper() {
+               :
+       }
+fi

and then using it in 

 stat_fail()  stat_done() ...

actually would break a lot of my private scripts when enabled splash, 
because i am using stat_XX() functions from functions of arch that i 
use in xterm. 

what would happen if you would use the splash_wrapper on a 
not-framebuffer capable device? i do not know what is actually 
the /sbin/${SPLASH}_wrapper doing, but will it fall back to the 
splash_wrapper() {
               :
       }
behaviour if it detects that it cannot use any framebuffer device?

this is of course a detail and i'm not mentioning it because i use 
this functions but in general. is there an option on what happens 
when "/sbin/${SPLASH}_wrapper $@" fails? 

maybe something like: "/sbin/${SPLASH}_wrapper $@ || echo 'splash 
failed - status: $@'"  
(this is a wild guess - no idea if it may work; i'm not familiar with 
all the code, just had a look at some diffs)

by the way: thanx for the branch. more convincing if oyu can browse 
git and have a look in a unproblematic way :)

- D

-- 
.·´¯`·.¸.·´¯`·.¸¸.·´¯`·.¸.·´¯`·.¸.·´¯`·.¸.·´¯`·.¸¸.·´
            °        °           °
             °      °            °
     ><((((º>      °              °
                    °            °
                   °            <º)))><
                  <º)))><