[arch-dev-public] [Patch] makechrootpkg: fixed support for splitted package

Eric Bélanger snowmaniscool at gmail.com
Thu Aug 13 03:34:29 EDT 2009


On Wed, Aug 12, 2009 at 4:53 PM, Aaron Griffin<aaronmgriffin at gmail.com> wrote:
> I merged and pushed the split package support for makechrootpkg.
>
> Regarding the namcap issue, I did it a little differently.
> For some reason I always forget the order:
>    >/dev/null 2>&1 #works fine
>    2>&1 >/dev/null #does not
>
> However, I just looked up your change in man bash...
>   &>/dev/null is equal to >/dev/null 2>&1
> So I fixed that in the next patch
>

Thanks. Another small patch to remove a superfluous parenthesis:

 --- makechrootpkg       2009-08-13 03:28:12.000000000 -0400
+++ /usr/sbin/makechrootpkg     2009-08-13 03:29:03.000000000 -0400
@@ -254,10 +254,10 @@
     for f in ${chrootdir}/union/srcdest/*; do
         [ -e "$f" ] || continue
         if [ -n "$SRCDEST" ]; then
-            echo "Moving downloaded source file ($(basename $f) to ${SRCDEST}"
+            echo "Moving downloaded source file $(basename $f) to ${SRCDEST}"
             mv "$f" "${SRCDEST}"
         else
-            echo "Moving downloaded source file ($(basename $f) to ${WORKDIR}"
+            echo "Moving downloaded source file $(basename $f) to ${WORKDIR}"
             mv "$f" "${WORKDIR}"
         fi
     done
-------------- next part --------------
A non-text attachment was scrubbed...
Name: makechrootpkg-src_move.patch
Type: text/x-patch
Size: 677 bytes
Desc: not available
URL: <http://www.archlinux.org/pipermail/arch-dev-public/attachments/20090813/57ac452d/attachment.bin>


More information about the arch-dev-public mailing list