[arch-dev-public] [Patch] dbscripts: fix for any arch support

Eric Bélanger snowmaniscool at gmail.com
Tue Aug 18 20:35:13 EDT 2009


On Tue, Aug 18, 2009 at 6:57 PM, Aaron Griffin<aaronmgriffin at gmail.com> wrote:
> On Fri, Aug 14, 2009 at 10:09 PM, Eric Bélanger<snowmaniscool at gmail.com> wrote:
>> On Fri, Aug 14, 2009 at 10:26 PM, Eric Bélanger<snowmaniscool at gmail.com> wrote:
>>> On Fri, Aug 14, 2009 at 9:44 PM, Eric Bélanger<snowmaniscool at gmail.com> wrote:
>>
>> Another change, will fix commit:
>> make-sourceball: license skip is NOT a failure
>> http://projects.archlinux.org/?p=dbscripts.git;a=commit;h=891e4f353d098a639c3b1d09d45987f0908b0d38
>>
>> This patch will remove skip licences from failed.txt
>>
>>
>> --- /arch/misc-scripts/make-sourceball  2009-03-12 17:54:35.000000000 -0400
>> +++ make-sourceball     2009-08-14 22:54:59.000000000 -0400
>> @@ -63,7 +63,7 @@
>>         done
>>     done
>>
>> -    return 1
>> +    return 0
>>  }
>>
>>  create_srcpackage() {
>
> Hmm this change makes it so the chk_license function never fails, and
> it needs to. Otherwise we get tarballs for every package regardless of
> license
>

The problem that I wanted to fix was that failed.txt is cluttered by
packages that have licenses for which we don't want to make tarballs
for (GPL3, BSD MIT, etc).  I don't think these should be treated as
failures as we expect the script to not make tarballs for them.  I
guess I'll need to come up with a better implementation unless you
want these packages in  failed.txt


More information about the arch-dev-public mailing list