[arch-dev-public] [PATCH] makechrootpkg: Use the host's SRCDEST and PKGDEST if they are defined

[Aaron Griffin]

On Wed, Nov 4, 2009 at 8:02 PM, Eric Bélanger <snowmaniscool at gmail.com> wrote:
> Signed-off-by: Eric Bélanger <snowmaniscool at gmail.com>
> ---
>  makechrootpkg |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/makechrootpkg b/makechrootpkg
> index 5095425..d1dcf32 100755
> --- a/makechrootpkg
> +++ b/makechrootpkg
> @@ -150,6 +150,9 @@ if [ "$REPACK" != "1" ]; then
>     rm -rf "$uniondir/build/"*
>  fi
>
> +eval $(grep '^SRCDEST=' /etc/makepkg.conf)
> +eval $(grep '^PKGDEST=' /etc/makepkg.conf)
> +
>  [ -d "$uniondir/pkgdest" ] || mkdir "$uniondir/pkgdest"
>  if ! grep "PKGDEST=/pkgdest" "$uniondir/etc/makepkg.conf" >/dev/null 2>&1; then
>     echo "Setting PKGDEST in makepkg.conf"

The eval seems slightly dangerous to me... does anyone else have this
concern, or am I being too careful?