[arch-dev-public] [PATCH 0/7] *** SUBJECT HERE ***

Dan McGee dan at archlinux.org
Mon Sep 28 00:16:19 EDT 2009


In the spirit of Eli making a bunch of patches for the AUR, I finally decided
to sit down tonight and figure out why the heck namcap was sucking it up, and
did a little code cleanup along the way. namcap.py is now a bit cleaner and
separated into functions, and the real treat is namcap is a hell of a lot
faster now that I found the bottleneck, which was the depends hook. The first 6
patches in this series lead up to the 7th, which is where the speed increase is
found.

Let me know what you see, otherwise it would be cool to get this in and a new
namcap release made, as it has rather dramatic effects with regards to speed.

If you don't like patches, you can get all this from my git tree as well:
http://code.toofishes.net/cgit/dan/namcap.git/log/?h=working

-Dan

Dan McGee (7):
  Rename 'tags' to 'namcap-tags'
  Only process tags if necessary
  Move extracted variable to the correct scope
  Only do active_modules check once
  Move PKGBUILD processing to a function
  Move real package processing to a function
  Make the depends module not suck

 Namcap/depends.py |  104 +++++++++++++++++++-------------
 README            |   10 ++--
 namcap-tags       |   65 ++++++++++++++++++++
 namcap.py         |  173 +++++++++++++++++++++++++++--------------------------
 setup.py          |    2 +-
 tags              |   65 --------------------
 tests/tags-check  |    4 +-
 7 files changed, 224 insertions(+), 199 deletions(-)
 create mode 100644 namcap-tags
 delete mode 100644 tags



More information about the arch-dev-public mailing list