[arch-dev-public] [PATCH 1/4] create-filelists: general cleanups

Dan McGee dan at archlinux.org
Sat Feb 27 13:01:33 EST 2010


* Specify lock name once
* Use new script name everywhere
* Clean up tabs/spaces and add a modeline. This isn't necessarily the one we
  wanted to standardize on, but I picked the one the entire file is written
  to at the moment.

Signed-off-by: Dan McGee <dan at archlinux.org>
---
 cron-jobs/create-filelists |   23 +++++++++++++----------
 1 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/cron-jobs/create-filelists b/cron-jobs/create-filelists
index c9d7db9..e90da00 100755
--- a/cron-jobs/create-filelists
+++ b/cron-jobs/create-filelists
@@ -3,27 +3,28 @@
 reposdir="/srv/ftp"
 targetdir="/srv/ftp"
 repos="core extra testing community community-testing"
+lock="/tmp/create-filelists.lock"
 
 . "$(dirname $0)/../db-functions"
 . "$(dirname $0)/../config"
 
-if [ -f "/tmp/createFileList.lock" ]; then
-    echo "Error: createFileList allready in progress."
+if [ -f "$lock" ]; then
+    echo "Error: create-filelists already in progress."
     exit 1
 fi
 
-touch "/tmp/createFileList.lock" || exit 1
-TMPDIR="$(mktemp -d /tmp/createFileList.XXXXXX)" || exit 1
-CACHEDIR="$(mktemp -d /tmp/createFileList.XXXXXX)" || exit 1
+touch "$lock" || exit 1
+TMPDIR="$(mktemp -d /tmp/create-filelists.XXXXXX)" || exit 1
+CACHEDIR="$(mktemp -d /tmp/create-filelists.XXXXXX)" || exit 1
 
 #adjust the nice level to run at a lower priority
 /usr/bin/renice +10 -p $$ > /dev/null
 
 case "${DBEXT}" in
-	*.gz)  TAR_OPT="z" ;;
-	*.bz2) TAR_OPT="j" ;;
-	*.xz)  TAR_OPT="J" ;;
-	*) echo "Unknown compression type for DBEXT=${DBEXT}" && exit 1 ;;
+    *.gz)  TAR_OPT="z" ;;
+    *.bz2) TAR_OPT="j" ;;
+    *.xz)  TAR_OPT="J" ;;
+    *) echo "Unknown compression type for DBEXT=${DBEXT}" && exit 1 ;;
 esac
 
 FILESEXT="${DBEXT//db/files}"
@@ -77,5 +78,7 @@ done
 cd - >/dev/null
 rm -rf "$TMPDIR" || exit 1
 rm -rf "$CACHEDIR" || exit 1
-rm -f "/tmp/createFileList.lock" || exit 1
+rm -f "$lock" || exit 1
 # echo 'done'
+
+# vim: set ts=4 sw=4 et ft=sh:
-- 
1.7.0



More information about the arch-dev-public mailing list